On Sunday 28 January 2007 07:15, [EMAIL PROTECTED] wrote:

I'm not picky about this patch, but it does seem worth noting:

> Modified: trunk/languages/lua/Lua/build.pm
> ===========================================================================
>=== --- trunk/languages/lua/Lua/build.pm    (original)
> +++ trunk/languages/lua/Lua/build.pm    Sun Jan 28 07:15:14 2007
> @@ -1136,6 +1136,23 @@
>  
>  sub BuildReturn {
>      my ( $parser, $exprs ) = @_;
> +    if ( scalar @{$exprs} == 1 ) {
> +        my $expr = $exprs->[0];
> +        if ( scalar $expr->[1] ) {
> +            my @opcodes = @{ $expr->[1] };
> +            if ( scalar @opcodes and $opcodes[-1]->isa('CallOp') ) {

... all of those uses of the scalar operator are unnecessary.  They're not 
harmful, just unnecessary.

-- c

Reply via email to