Author: jkeenan
Date: Sun Mar 25 18:24:46 2007
New Revision: 17755

Modified:
   branches/reconfigure/Configure.pl

Log:
1.  exit(0) need only be coded once, after end of if-else block.  Move
print_conclusion() inside 'else' stanza (as that's the only circumstance under
which it can be called).
2.  Add comments naming package where each method originates.


Modified: branches/reconfigure/Configure.pl
==============================================================================
--- branches/reconfigure/Configure.pl   (original)
+++ branches/reconfigure/Configure.pl   Sun Mar 25 18:24:46 2007
@@ -31,6 +31,7 @@
 # warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 # Installation directories:
 
+# from Parrot::Configure::Options
 my $args = process_options( {
     argv            => [ @ARGV ],
     script          => $0,
@@ -41,29 +42,33 @@
 
 my %args = %$args;
 
+# from Parrot::Configure::Messages
 print_introduction($parrot_version);
 
 my $conf = Parrot::Configure->new;
 
+# from Parrot::Configure::Step::List
 $conf->add_steps(get_steps_list());
 
+# from Parrot::Configure::Data
 $conf->options->set(%args);
 
 if ( exists $args{step} ) {
+    # from Parrot::Configure::Data
     $conf->data()->slurp();
+    # from Parrot::Configure
     $conf->runstep( $args{step} );
     print "\n";
-    exit(0);
 }
 else {
-
     # Run the actual steps
+    # from Parrot::Configure
     $conf->runsteps or exit(1);
+    # tell users what to do next
+    # from Parrot::Configure::Messages
+    print_conclusion($conf->data->get('make'));
 }
 
-# tell users what to do next
-print_conclusion($conf->data->get('make'));
-
 exit(0);
 
 ################### DOCUMENTATION ###################

Reply via email to