[svn:parrot] r18156 - in trunk/lib/Parrot: Configure Ops2c

[jkeenan]

Author: jkeenan
Date: Wed Apr 11 16:27:33 2007
New Revision: 18156

Modified:
   trunk/lib/Parrot/Configure/Messages.pm
   trunk/lib/Parrot/Configure/Options.pm
   trunk/lib/Parrot/Ops2c/Utils.pm

Log:
Conform, where appropriate to Perl::Critic policy requiring explicit return
values in subroutines.


Modified: trunk/lib/Parrot/Configure/Messages.pm
==============================================================================
--- trunk/lib/Parrot/Configure/Messages.pm      (original)
+++ trunk/lib/Parrot/Configure/Messages.pm      Wed Apr 11 16:27:33 2007
@@ -25,6 +25,7 @@
 Since you're running this program, you obviously have Perl 5--I'll be pulling
 some defaults from its configuration.
 END
+    return 1;
 }
 
 sub print_conclusion {
@@ -41,6 +42,7 @@
         The Parrot Team
 
 END
+    return 1;
 }
 
 1;

Modified: trunk/lib/Parrot/Configure/Options.pm
==============================================================================
--- trunk/lib/Parrot/Configure/Options.pm       (original)
+++ trunk/lib/Parrot/Configure/Options.pm       Wed Apr 11 16:27:33 2007
@@ -67,6 +67,7 @@
     my $argsref = shift;
     print "Parrot Version $argsref->{parrot_version} Configure 2.0\n";
     print "$argsref->{svnid}\n";
+    return 1;
 }
 
 sub print_help {
@@ -187,6 +188,7 @@
     --mandir=DIR            man documentation [PREFIX/man]
 
 EOT
+    return 1;
 }
 
 1;

Modified: trunk/lib/Parrot/Ops2c/Utils.pm
==============================================================================
--- trunk/lib/Parrot/Ops2c/Utils.pm     (original)
+++ trunk/lib/Parrot/Ops2c/Utils.pm     Wed Apr 11 16:27:33 2007
@@ -309,6 +309,7 @@
 $self->{sym_export} extern op_lib_t *$self->{init_func}(long init);
 
 END_C
+    return 1;
 }
 
 sub _print_run_core_func_decl_header {
@@ -317,6 +318,7 @@
     if ( $self->{trans}->can("run_core_func_decl") ) {
         my $run_core_func = $self->{trans}->run_core_func_decl( $self->{base} 
);
         print $fh "$run_core_func;\n";
+        return 1;
     }
     else {
         return;
@@ -334,6 +336,7 @@
  * vim: expandtab shiftwidth=4:
  */
 END_C
+    return 1;
 }
 
 =head2 C<print_c_source_top()>
@@ -428,6 +431,7 @@
 
     if ( $self->{trans}->can("ops_addr_decl") ) {
         print $fh $self->{trans}->ops_addr_decl( $self->{bs} );
+        return 1;
     }
     else {
         return;
@@ -441,6 +445,7 @@
         print $fh $self->{trans}->run_core_func_decl( $self->{base} );
         print $fh "\n{\n";
         print $fh $self->{trans}->run_core_func_start;
+        return 1;
     }
     else {
         return;
@@ -522,6 +527,7 @@
 END_C
         print $fh $self->{trans}->run_core_after_addr_table( $self->{bs} );
     }
+    return 1;
 }
 
 sub _print_goto_opcode {
@@ -576,6 +582,7 @@
         print $fh $self->{trans}->run_core_finish( $self->{base} );
     }
     close($fh) || die "Unable to close after writing: $!";
+    return 1;
 }
 
 =head2 C<print_c_source_bottom()>
@@ -766,6 +773,7 @@
 
 END_C
     }
+    return 1;
 }
 
 sub _op_lookup {
@@ -889,6 +897,7 @@
 static void hop_deinit(void) {}
 END_C
     }
+    return 1;
 }
 
 sub _print_op_lib_descriptor {
@@ -916,6 +925,7 @@
 };
 
 END_C
+    return 1;
 }
 
 sub _generate_init_func {
@@ -951,6 +961,7 @@
 }
 
 END_C
+    return 1;
 }
 
 sub _print_dynamic_lib_load {
@@ -974,6 +985,7 @@
 }
 END_C
     }
+    return 1;
 }
 
 sub _rename_source {