Author: paultcochrane
Date: Wed May 9 02:36:09 2007
New Revision: 18479
Modified:
trunk/lib/Parrot/Configure/Step.pm
trunk/lib/Parrot/Test.pm
Log:
[lib] Converted some 2-arg open()s to 3-arg form as per coding standards
Modified: trunk/lib/Parrot/Configure/Step.pm
==============================================================================
--- trunk/lib/Parrot/Configure/Step.pm (original)
+++ trunk/lib/Parrot/Configure/Step.pm Wed May 9 02:36:09 2007
@@ -447,8 +447,8 @@
close STDOUT or die "Can't close stdout" if $out;
close STDERR or die "Can't close stderr" if $err;
- open STDOUT, ">&OLDOUT" or die "Can't restore stdout" if $out;
- open STDERR, ">&OLDERR" or die "Can't restore stderr" if $err;
+ open STDOUT, ">&", \*OLDOUT or die "Can't restore stdout" if $out;
+ open STDERR, ">&", \*OLDERR or die "Can't restore stderr" if $err;
if ($verbose) {
foreach ( $out, $err ) {
@@ -590,7 +590,7 @@
# reenable STDERR
close STDERR;
- open STDERR, ">&OLDERR";
+ open STDERR, ">&", \*OLDERR;
# slurp stderr
my $out_err = _slurp('./test.err');
Modified: trunk/lib/Parrot/Test.pm
==============================================================================
--- trunk/lib/Parrot/Test.pm (original)
+++ trunk/lib/Parrot/Test.pm Wed May 9 02:36:09 2007
@@ -288,8 +288,8 @@
close STDOUT or die "Can't close stdout" if $out;
close STDERR or die "Can't close stderr" if $err;
- open STDOUT, ">&OLDOUT" or die "Can't restore stdout" if $out;
- open STDERR, ">&OLDERR" or die "Can't restore stderr" if $err;
+ open STDOUT, ">&", \*OLDOUT or die "Can't restore stdout" if $out;
+ open STDERR, ">&", \*OLDERR or die "Can't restore stderr" if $err;
return (
( $exit_code < 0 ) ? $exit_code
