Author: petdance
Date: Thu Jul  5 22:33:52 2007
New Revision: 19638

Modified:
   trunk/config/gen/makefiles/root.in
   trunk/src/stm/backend.c

Log:
last_read looks like it should be used in this for loop.  Anyone smarter than 
me able to check?

Modified: trunk/config/gen/makefiles/root.in
==============================================================================
--- trunk/config/gen/makefiles/root.in  (original)
+++ trunk/config/gen/makefiles/root.in  Thu Jul  5 22:33:52 2007
@@ -1721,6 +1721,8 @@
     \
     -erroff=E_FUNC_ARG_UNUSED \
     -erroff=E_STMT_NOT_REACHED \
+    -erroff=E_NOP_IF_STMT \
+    -erroff=E_NOP_ELSE_STMT \
     -erroff=E_CASE_FALLTHRU \
 
 sunlint :

Modified: trunk/src/stm/backend.c
==============================================================================
--- trunk/src/stm/backend.c     (original)
+++ trunk/src/stm/backend.c     Thu Jul  5 22:33:52 2007
@@ -378,7 +378,8 @@
  * are all valid.
  */
 static int
-get_read_valid_depth(Interp *interp, STM_tx_log *log) {
+get_read_valid_depth(Interp *interp, STM_tx_log *log /*NN*/)
+{
     int i;
     int validp    = 1;
     int cur_depth = 1;
@@ -395,6 +396,7 @@
         else
             last_read = get_sublog(log, cur_depth + 1)->first_read - 1;
 
+        /* XXX last_read is never used again.  Should it be in the condition 
for the for loop? */
         for (i = current->first_read; i <= log->last_read; ++i) {
             void *found_version;
 

Reply via email to