Author: coke
Date: Fri Jul 18 12:02:44 2008
New Revision: 29592

Modified:
   trunk/lib/Parrot/Harness/Smoke.pm

Log:
[test] minor update to Smoke.pm that happens to also pass all the codingstd
tests. Courtesy Michael Peters via RT #55954.


Modified: trunk/lib/Parrot/Harness/Smoke.pm
==============================================================================
--- trunk/lib/Parrot/Harness/Smoke.pm   (original)
+++ trunk/lib/Parrot/Harness/Smoke.pm   Fri Jul 18 12:02:44 2008
@@ -95,20 +95,12 @@
         'Optimize'     => ($PConfig{optimize} || 'none'),
         'Perl Version' => (sprintf('%vd', $^V) . " $PConfig{archname}"),
         'Platform'     => $PConfig{osname},
-        'SVN Revision' => _get_svn_revision(),
+        'SVN Revision' => $PConfig{revision},
         'Version'      => $PConfig{VERSION},
     );
 }
 
-# TODO expand this to handle svk and/or git checkouts too
-sub _get_svn_revision {
-    foreach my $line (`svn info`) {
-        return $1 if $line =~ /^Revision:\s*(\d+)/;
-    }
-    return 'unknown';
-}
-
-# TODO expand this to more than just GCC
+# this can be expanded to more than just GCC
 sub _get_compiler_version {
     my $compiler = $PConfig{cc};
     if($compiler eq 'gcc') {

Reply via email to