[svn:parrot] r29653 - branches/pdd13pbc/src/pmc

[infinoid]

Author: infinoid
Date: Mon Jul 21 06:18:28 2008
New Revision: 29653

Modified:
   branches/pdd13pbc/src/pmc/packfiledirectory.pmc

Log:
[PDD13]
* Remove an unused variable.
* If the index is out of bounds, raise an exception, don't just return PMCNULL. 
 This
  fixes the following warning:
  ./src/pmc/packfiledirectory.pmc:102: warning: return from incompatible 
pointer type


Modified: branches/pdd13pbc/src/pmc/packfiledirectory.pmc
==============================================================================
--- branches/pdd13pbc/src/pmc/packfiledirectory.pmc     (original)
+++ branches/pdd13pbc/src/pmc/packfiledirectory.pmc     Mon Jul 21 06:18:28 2008
@@ -60,7 +60,7 @@
         PMC *rv;
         int pmc_type;
         if(index < 0 || index >= (INTVAL)pfd->num_segments)
-            return PMCNULL;
+            real_exception(interp, NULL, E_IndexError, "PackfileDirectory: 
index out of bounds!");
         pfseg = pfd->segments[index];
         switch(pfseg->type) {
             case PF_DIR_SEG:
@@ -97,9 +97,8 @@
         PackFile_Directory *pfd = PMC_data_typed(SELF, PackFile_Directory *);
         PackFile_Segment *pfseg;
         PMC *rv;
-        int pmc_type;
         if(index < 0 || index >= (INTVAL)pfd->num_segments)
-            return PMCNULL;
+            real_exception(interp, NULL, E_IndexError, "PackfileDirectory: 
index out of bounds!");
         pfseg = pfd->segments[index];
         return const_string(interp, pfseg->name);
     }