Author: jkeenan
Date: Sun Jul 27 07:44:08 2008
New Revision: 29799
Modified:
branches/parallel/t/steps/auto_gcc-01.t
branches/parallel/t/steps/auto_glibc-01.t
branches/parallel/t/steps/inter_yacc-01.t
branches/parallel/t/steps/inter_yacc-02.t
Log:
[configure] Fine-tuning of tests for configuration steps. Clarify POD.
Provide inline comments functioning as subheads where tests previously found
in multiple files have been moved into a single file. Use
Parrot::Configure::Test::test_step_constructor_and_description() to eliminate
repeated code. Delete outdated comments.
Modified: branches/parallel/t/steps/auto_gcc-01.t
==============================================================================
--- branches/parallel/t/steps/auto_gcc-01.t (original)
+++ branches/parallel/t/steps/auto_gcc-01.t Sun Jul 27 07:44:08 2008
@@ -20,6 +20,8 @@
);
use IO::CaptureOutput qw | capture |;
+########## regular ##########
+
my $args = process_options( {
argv => [],
mode => q{configure},
@@ -32,17 +34,18 @@
test_step_thru_runstep($conf, q{init::defaults}, $args);
test_step_thru_runstep( $conf, q{inter::progs}, $args );
-my ($task, $step_name, $step, $ret);
my $pkg = q{auto::gcc};
$conf->add_steps($pkg);
$conf->options->set(%{$args});
-$step = test_step_constructor_and_description($conf);
+my $step = test_step_constructor_and_description($conf);
ok($step->runstep($conf), "runstep returned true value");
$conf->replenish($serialized);
+########## _evaluate_gcc() ##########
+
rerun_defaults_for_testing($conf, $args );
$conf->add_steps($pkg);
$conf->options->set(%{$args});
@@ -55,6 +58,8 @@
$conf->replenish($serialized);
+########## _evaluate_gcc() ##########
+
rerun_defaults_for_testing($conf, $args );
$conf->add_steps($pkg);
$conf->options->set(%{$args});
@@ -70,6 +75,8 @@
$conf->replenish($serialized);
+########## _evaluate_gcc(); verbose ##########
+
$args = process_options( {
argv => [ q{--verbose} ],
mode => q{configure},
@@ -93,6 +100,8 @@
$conf->replenish($serialized);
+########## _evaluate_gcc() ##########
+
$args = process_options( {
argv => [],
mode => q{configure},
@@ -112,6 +121,8 @@
$conf->replenish($serialized);
+########## _evaluate_gcc(); verbose ##########
+
$args = process_options( {
argv => [ q{--verbose} ],
mode => q{configure},
@@ -135,6 +146,8 @@
$conf->replenish($serialized);
+########## _evaluate_gcc() ##########
+
rerun_defaults_for_testing($conf, $args );
$conf->add_steps($pkg);
$conf->options->set(%{$args});
@@ -157,6 +170,8 @@
$conf->replenish($serialized);
+########## _evaluate_gcc() ##########
+
$args = process_options( {
argv => [],
mode => q{configure},
@@ -182,6 +197,8 @@
$conf->replenish($serialized);
+########## _evaluate_gcc(); verbose ##########
+
$args = process_options( {
argv => [ q{--verbose} ],
mode => q{configure},
@@ -208,6 +225,8 @@
$conf->replenish($serialized);
+########## _evaluate_gcc() ##########
+
$args = process_options( {
argv => [ ],
mode => q{configure},
@@ -226,6 +245,8 @@
$conf->replenish($serialized);
+########## _evaluate_gcc(); maintaiiner; cage ##########
+
$args = process_options( {
argv => [ q{--maintainer}, q{--cage} ],
mode => q{configure},
@@ -246,6 +267,8 @@
$conf->replenish($serialized);
+########## _evaluate_gcc(); miniparrot ##########
+
$args = process_options( {
argv => [ q{--miniparrot} ],
mode => q{configure},
@@ -267,6 +290,8 @@
$conf->replenish($serialized);
+########## _evaluate_gcc() ##########
+
$args = process_options( {
argv => [ ],
mode => q{configure},
@@ -297,7 +322,7 @@
=head1 NAME
-auto_gcc-01.t - test config::auto::gcc
+auto_gcc-01.t - test auto::gcc
=head1 SYNOPSIS
@@ -307,7 +332,7 @@
The files in this directory test functionality used by F<Configure.pl>.
-The tests in this file test subroutines exported by config::auto::gcc.
+The tests in this file test auto::gcc.
=head1 AUTHOR
Modified: branches/parallel/t/steps/auto_glibc-01.t
==============================================================================
--- branches/parallel/t/steps/auto_glibc-01.t (original)
+++ branches/parallel/t/steps/auto_glibc-01.t Sun Jul 27 07:44:08 2008
@@ -14,10 +14,11 @@
use Parrot::Configure::Options qw( process_options );
use Parrot::Configure::Test qw(
test_step_thru_runstep
- rerun_defaults_for_testing
test_step_constructor_and_description
);
+########## regular ##########
+
my $args = process_options( {
argv => [],
mode => q{configure},
@@ -40,6 +41,8 @@
$conf->replenish($serialized);
+########## _evaluate_glibc() ##########
+
$conf->options->set(%{$args});
$step = test_step_constructor_and_description($conf);
@@ -61,7 +64,7 @@
=head1 NAME
-auto_glibc-01.t - test config::auto::glibc
+auto_glibc-01.t - test auto::glibc
=head1 SYNOPSIS
@@ -71,7 +74,7 @@
The files in this directory test functionality used by F<Configure.pl>.
-The tests in this file test the 'normal functioning' of config::auto::glibc.
+The tests in this file test the 'normal functioning' of auto::glibc.
=head1 AUTHOR
Modified: branches/parallel/t/steps/inter_yacc-01.t
==============================================================================
--- branches/parallel/t/steps/inter_yacc-01.t (original)
+++ branches/parallel/t/steps/inter_yacc-01.t Sun Jul 27 07:44:08 2008
@@ -15,7 +15,6 @@
use Parrot::Configure::Options qw( process_options );
use Parrot::Configure::Test qw(
test_step_thru_runstep
- rerun_defaults_for_testing
test_step_constructor_and_description
);
use Tie::Filehandle::Preempt::Stdin;
@@ -148,7 +147,7 @@
=head1 NAME
-inter_yacc-01.t - test config::inter::yacc
+inter_yacc-01.t - test inter::yacc
=head1 SYNOPSIS
@@ -158,9 +157,7 @@
The files in this directory test functionality used by F<Configure.pl>.
-The tests in this file test subroutines exported by config::inter::yacc. In
-this case, only the C<--ask> option is provided. Because the C<--maintainer>
-option is not provided, the step is skipped and no prompt is ever reached.
+The tests in this file test inter::yacc.
=head1 AUTHOR
Modified: branches/parallel/t/steps/inter_yacc-02.t
==============================================================================
--- branches/parallel/t/steps/inter_yacc-02.t (original)
+++ branches/parallel/t/steps/inter_yacc-02.t Sun Jul 27 07:44:08 2008
@@ -15,10 +15,11 @@
use Parrot::Configure::Options qw( process_options );
use Parrot::Configure::Test qw(
test_step_thru_runstep
- rerun_defaults_for_testing
test_step_constructor_and_description
);
+########## ask; maintainer; $ENV{TEST_YACC} ##########
+
my $args = process_options(
{
argv => [ q{--ask}, q{--maintainer} ],
