On Wed, Jul 30, 2008 at 12:42:24PM -0700, [EMAIL PROTECTED] wrote:
> Log:
> [rakudo] small refactor for clarity
> 
> Modified: trunk/languages/perl6/src/parser/actions.pm
> ==============================================================================
> --- trunk/languages/perl6/src/parser/actions.pm       (original)
> +++ trunk/languages/perl6/src/parser/actions.pm       Wed Jul 30 12:42:24 2008
> @@ -87,6 +87,7 @@
>          if $expr.WHAT() eq 'Block' && !$expr.blocktype() {
>              $expr.blocktype('immediate');
>          }

I know this isn't part of the patch, but in general we should
be writing

    if $expr.HOW().isa(PAST::Block) 

instead of

    if $expr.WHAT() eq 'Block'

(Yes, versions of PAST prior to P6object didn't support .isa, 
but now that it's there we should probably use it.)

Pm

Reply via email to