Author: coke
Date: Tue Nov 11 05:45:36 2008
New Revision: 32534

Modified:
   trunk/languages/BASIC/compiler/RT_platform.pir
   trunk/languages/pipp/src/common/php_string.pir

Log:
[CAGE] magic constants are bad. Courtesy jimmy++ 

... I have no idea if this impacts BASIC, but it certainly looks reasonable.


Modified: trunk/languages/BASIC/compiler/RT_platform.pir
==============================================================================
--- trunk/languages/BASIC/compiler/RT_platform.pir      (original)
+++ trunk/languages/BASIC/compiler/RT_platform.pir      Tue Nov 11 05:45:36 2008
@@ -1,7 +1,9 @@
 .include "RT_platform_win32.pir"
 .include "RT_platform_ANSIscreen.pir"
+.include "sysinfo.pasm"
+
 .sub _platform_setup           # void platform_setup(void)
-       sysinfo S0, 4
+       sysinfo S0, .SYSINFO_PARROT_OS
        ne S0, "MSWin32", NOTWIN
        _win32_setup()
        branch END
@@ -9,7 +11,7 @@
 END:   noop
 .end
 .sub _platform_shutdown
-       sysinfo S0, 4
+       sysinfo S0, .SYSINFO_PARROT_OS
        ne S0, "MSWin32", NOTWIN
        _win32_shutdown()
        branch END
@@ -20,7 +22,7 @@
        find_global $P0, "PRINTCOL"
        set $P0["value"], 0
        store_global "PRINTCOL", $P0
-       sysinfo S0, 4
+       sysinfo S0, .SYSINFO_PARROT_OS
        ne S0, "MSWin32", NOTWIN
        _win32_screen_clear()
        branch END
@@ -30,13 +32,13 @@
 
 #SCREEN_SETXCUR:
 #      set I1, P6[.VALUE]
-#      sysinfo S0, 4
+#      sysinfo S0, .SYSINFO_PARROT_OS
 #      eq S0, "MSWin32", WIN32_SCREEN_SETXCUR
 #      branch ANSI_SCREEN_SETXCUR
 #
 #SCREEN_SETYCUR:
 #      set I1, P6[.VALUE]
-#      sysinfo S0, 4
+#      sysinfo S0, .SYSINFO_PARROT_OS
 #      eq S0, "MSWin32", WIN32_SCREEN_SETYCUR
 #      branch ANSI_SCREEN_SETYCUR
 #

Modified: trunk/languages/pipp/src/common/php_string.pir
==============================================================================
--- trunk/languages/pipp/src/common/php_string.pir      (original)
+++ trunk/languages/pipp/src/common/php_string.pir      Tue Nov 11 05:45:36 2008
@@ -120,6 +120,8 @@
 
 =cut
 
+.include 'sysinfo.pasm'
+
 .sub 'basename'
     .param pmc args :slurpy
     .local string path
@@ -130,7 +132,7 @@
     if $I0 goto L1
     .RETURN_NULL()
   L1:
-    sysinfo $S0, 4
+    $S0 = sysinfo .SYSINFO_PARROT_OS
     if $S0 == 'MSWin32' goto L2
     if $S0 == 'netware' goto L2
     separator = '/'

Reply via email to