rbb 01/01/01 17:33:05
Modified: . CHANGES
lib apr_pools.c
Log:
Remove the ability to allocate out of a NULL pool. This was always a bad
idea, because it opened up memory leaks. It is very likely that this will
expose some seg faults and some memory leaks, but I have tried to find and
fix most of the already.
Revision Changes Path
1.35 +3 -0 apr/CHANGES
Index: CHANGES
===================================================================
RCS file: /home/cvs/apr/CHANGES,v
retrieving revision 1.34
retrieving revision 1.35
diff -u -r1.34 -r1.35
--- CHANGES 2001/01/02 01:19:07 1.34
+++ CHANGES 2001/01/02 01:33:05 1.35
@@ -1,5 +1,8 @@
Changes with APR b1
+ *) Remove the ability to allocate memory out of a NULL pool.
+ [Ryan Bloom]
+
*) Add an APR_GET_POOL macro to get a pool from any APR type that has
a pool. This requires that ALL apr types put the pool as the first
field in their structure. [Ryan Bloom]
1.76 +0 -6 apr/lib/apr_pools.c
Index: apr_pools.c
===================================================================
RCS file: /home/cvs/apr/lib/apr_pools.c,v
retrieving revision 1.75
retrieving revision 1.76
diff -u -r1.75 -r1.76
--- apr_pools.c 2000/12/31 18:04:59 1.75
+++ apr_pools.c 2001/01/02 01:33:05 1.76
@@ -940,12 +940,6 @@
nclicks = 1 + ((reqsize - 1) / CLICK_SZ);
size = nclicks * CLICK_SZ;
-
- if (a == NULL) {
- return malloc(reqsize);
- }
-
-
/* First, see if we have space in the block most recently
* allocated to this pool
*/
