cvs commit: apr-util/buckets apr_buckets_file.c apr_buckets_mmap.c

[jwoolley]

jwoolley    01/04/29 21:11:22

  Modified:    buckets  apr_buckets_file.c apr_buckets_mmap.c
  Log:
  Note the reason why the buckets code does not close files/mmaps itself
  
  Revision  Changes    Path
  1.41      +2 -0      apr-util/buckets/apr_buckets_file.c
  
  Index: apr_buckets_file.c
  ===================================================================
  RCS file: /home/cvs/apr-util/buckets/apr_buckets_file.c,v
  retrieving revision 1.40
  retrieving revision 1.41
  diff -u -d -u -r1.40 -r1.41
  --- apr_buckets_file.c        2001/04/11 19:07:04     1.40
  +++ apr_buckets_file.c        2001/04/30 04:11:19     1.41
  @@ -87,6 +87,8 @@
   static void file_destroy(void *data)
   {
       if (apr_bucket_shared_destroy(data)) {
  +        /* no need to close the file here; it will get
  +         * done automatically when the pool gets cleaned up */
           free(data);
       }
   }
  
  
  
  1.35      +2 -1      apr-util/buckets/apr_buckets_mmap.c
  
  Index: apr_buckets_mmap.c
  ===================================================================
  RCS file: /home/cvs/apr-util/buckets/apr_buckets_mmap.c,v
  retrieving revision 1.34
  retrieving revision 1.35
  diff -u -d -u -r1.34 -r1.35
  --- apr_buckets_mmap.c        2001/04/11 19:07:05     1.34
  +++ apr_buckets_mmap.c        2001/04/30 04:11:20     1.35
  @@ -79,7 +79,8 @@
       apr_bucket_mmap *m = data;
   
       if (apr_bucket_shared_destroy(m)) {
  -        /* XXX: apr_mmap_delete(m->mmap)? */
  +        /* no need to apr_mmap_delete(m->mmap) here... it will
  +         * get done automatically when the pool gets cleaned up. */
           free(m);
       }
   }