jwoolley 01/06/19 11:48:45
Modified: server error_bucket.c
buckets apr_buckets_eos.c apr_buckets_file.c
apr_buckets_flush.c apr_buckets_heap.c
apr_buckets_mmap.c apr_buckets_pipe.c
apr_buckets_pool.c apr_buckets_simple.c
apr_buckets_socket.c
Log:
The bucket_foo_create() functions do not need to use calloc() because
all of the members of the apr_bucket struct are always explicitly
initialized anyway... malloc() should be used instead.
Revision Changes Path
1.4 +1 -1 httpd-2.0/server/error_bucket.c
Index: error_bucket.c
===================================================================
RCS file: /home/cvs/httpd-2.0/server/error_bucket.c,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -d -u -r1.3 -r1.4
--- error_bucket.c 2001/04/11 19:07:01 1.3
+++ error_bucket.c 2001/06/19 18:48:21 1.4
@@ -90,7 +90,7 @@
AP_DECLARE(apr_bucket *) ap_bucket_error_create(int error,
const char *buf, apr_pool_t *p)
{
- apr_bucket *b = (apr_bucket *)calloc(1, sizeof(*b));
+ apr_bucket *b = (apr_bucket *)malloc(sizeof(*b));
APR_BUCKET_INIT(b);
return ap_bucket_error_make(b, error, buf, p);
1.26 +1 -1 apr-util/buckets/apr_buckets_eos.c
Index: apr_buckets_eos.c
===================================================================
RCS file: /home/cvs/apr-util/buckets/apr_buckets_eos.c,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -d -u -r1.25 -r1.26
--- apr_buckets_eos.c 2001/06/13 19:16:07 1.25
+++ apr_buckets_eos.c 2001/06/19 18:48:24 1.26
@@ -81,7 +81,7 @@
APU_DECLARE(apr_bucket *) apr_bucket_eos_create(void)
{
- apr_bucket *b = (apr_bucket *)calloc(1, sizeof(*b));
+ apr_bucket *b = (apr_bucket *)malloc(sizeof(*b));
APR_BUCKET_INIT(b);
return apr_bucket_eos_make(b);
1.46 +1 -1 apr-util/buckets/apr_buckets_file.c
Index: apr_buckets_file.c
===================================================================
RCS file: /home/cvs/apr-util/buckets/apr_buckets_file.c,v
retrieving revision 1.45
retrieving revision 1.46
diff -u -d -u -r1.45 -r1.46
--- apr_buckets_file.c 2001/06/18 21:57:10 1.45
+++ apr_buckets_file.c 2001/06/19 18:48:25 1.46
@@ -204,7 +204,7 @@
APU_DECLARE(apr_bucket *) apr_bucket_file_create(apr_file_t *fd,
apr_off_t offset, apr_size_t
len)
{
- apr_bucket *b = (apr_bucket *)calloc(1, sizeof(*b));
+ apr_bucket *b = (apr_bucket *)malloc(sizeof(*b));
APR_BUCKET_INIT(b);
return apr_bucket_file_make(b, fd, offset, len);
1.18 +1 -1 apr-util/buckets/apr_buckets_flush.c
Index: apr_buckets_flush.c
===================================================================
RCS file: /home/cvs/apr-util/buckets/apr_buckets_flush.c,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -d -u -r1.17 -r1.18
--- apr_buckets_flush.c 2001/06/13 19:16:11 1.17
+++ apr_buckets_flush.c 2001/06/19 18:48:26 1.18
@@ -81,7 +81,7 @@
APU_DECLARE(apr_bucket *) apr_bucket_flush_create(void)
{
- apr_bucket *b = (apr_bucket *)calloc(1, sizeof(*b));
+ apr_bucket *b = (apr_bucket *)malloc(sizeof(*b));
APR_BUCKET_INIT(b);
return apr_bucket_flush_make(b);
1.34 +1 -1 apr-util/buckets/apr_buckets_heap.c
Index: apr_buckets_heap.c
===================================================================
RCS file: /home/cvs/apr-util/buckets/apr_buckets_heap.c,v
retrieving revision 1.33
retrieving revision 1.34
diff -u -d -u -r1.33 -r1.34
--- apr_buckets_heap.c 2001/06/07 10:13:36 1.33
+++ apr_buckets_heap.c 2001/06/19 18:48:27 1.34
@@ -117,7 +117,7 @@
APU_DECLARE(apr_bucket *) apr_bucket_heap_create(
const char *buf, apr_size_t length, int copy, apr_size_t *w)
{
- apr_bucket *b = (apr_bucket *)calloc(1, sizeof(*b));
+ apr_bucket *b = (apr_bucket *)malloc(sizeof(*b));
APR_BUCKET_INIT(b);
return apr_bucket_heap_make(b, buf, length, copy, w);
1.38 +1 -1 apr-util/buckets/apr_buckets_mmap.c
Index: apr_buckets_mmap.c
===================================================================
RCS file: /home/cvs/apr-util/buckets/apr_buckets_mmap.c,v
retrieving revision 1.37
retrieving revision 1.38
diff -u -d -u -r1.37 -r1.38
--- apr_buckets_mmap.c 2001/06/19 02:57:18 1.37
+++ apr_buckets_mmap.c 2001/06/19 18:48:28 1.38
@@ -109,7 +109,7 @@
APU_DECLARE(apr_bucket *) apr_bucket_mmap_create(
apr_mmap_t *mm, apr_off_t start, apr_size_t length)
{
- apr_bucket *b = (apr_bucket *)calloc(1, sizeof(*b));
+ apr_bucket *b = (apr_bucket *)malloc(sizeof(*b));
APR_BUCKET_INIT(b);
return apr_bucket_mmap_make(b, mm, start, length);
1.36 +1 -1 apr-util/buckets/apr_buckets_pipe.c
Index: apr_buckets_pipe.c
===================================================================
RCS file: /home/cvs/apr-util/buckets/apr_buckets_pipe.c,v
retrieving revision 1.35
retrieving revision 1.36
diff -u -d -u -r1.35 -r1.36
--- apr_buckets_pipe.c 2001/06/13 19:16:13 1.35
+++ apr_buckets_pipe.c 2001/06/19 18:48:29 1.36
@@ -144,7 +144,7 @@
APU_DECLARE(apr_bucket *) apr_bucket_pipe_create(apr_file_t *p)
{
- apr_bucket *b = (apr_bucket *)calloc(1, sizeof(*b));
+ apr_bucket *b = (apr_bucket *)malloc(sizeof(*b));
APR_BUCKET_INIT(b);
return apr_bucket_pipe_make(b, p);
1.20 +1 -1 apr-util/buckets/apr_buckets_pool.c
Index: apr_buckets_pool.c
===================================================================
RCS file: /home/cvs/apr-util/buckets/apr_buckets_pool.c,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -d -u -r1.19 -r1.20
--- apr_buckets_pool.c 2001/06/18 21:39:27 1.19
+++ apr_buckets_pool.c 2001/06/19 18:48:31 1.20
@@ -162,7 +162,7 @@
APU_DECLARE(apr_bucket *) apr_bucket_pool_create(
const char *buf, apr_size_t length, apr_pool_t *pool)
{
- apr_bucket *b = (apr_bucket *)calloc(1, sizeof(*b));
+ apr_bucket *b = (apr_bucket *)malloc(sizeof(*b));
APR_BUCKET_INIT(b);
return apr_bucket_pool_make(b, buf, length, pool);
1.29 +2 -2 apr-util/buckets/apr_buckets_simple.c
Index: apr_buckets_simple.c
===================================================================
RCS file: /home/cvs/apr-util/buckets/apr_buckets_simple.c,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -d -u -r1.28 -r1.29
--- apr_buckets_simple.c 2001/06/13 19:16:15 1.28
+++ apr_buckets_simple.c 2001/06/19 18:48:32 1.29
@@ -112,7 +112,7 @@
APU_DECLARE(apr_bucket *) apr_bucket_immortal_create(
const char *buf, apr_size_t length)
{
- apr_bucket *b = (apr_bucket *)calloc(1, sizeof(*b));
+ apr_bucket *b = (apr_bucket *)malloc(sizeof(*b));
APR_BUCKET_INIT(b);
return apr_bucket_immortal_make(b, buf, length);
@@ -149,7 +149,7 @@
APU_DECLARE(apr_bucket *) apr_bucket_transient_create(
const char *buf, apr_size_t length)
{
- apr_bucket *b = (apr_bucket *)calloc(1, sizeof(*b));
+ apr_bucket *b = (apr_bucket *)malloc(sizeof(*b));
APR_BUCKET_INIT(b);
return apr_bucket_transient_make(b, buf, length);
1.25 +1 -1 apr-util/buckets/apr_buckets_socket.c
Index: apr_buckets_socket.c
===================================================================
RCS file: /home/cvs/apr-util/buckets/apr_buckets_socket.c,v
retrieving revision 1.24
retrieving revision 1.25
diff -u -d -u -r1.24 -r1.25
--- apr_buckets_socket.c 2001/06/13 19:16:17 1.24
+++ apr_buckets_socket.c 2001/06/19 18:48:33 1.25
@@ -139,7 +139,7 @@
APU_DECLARE(apr_bucket *) apr_bucket_socket_create(apr_socket_t *p)
{
- apr_bucket *b = (apr_bucket *)calloc(1, sizeof(*b));
+ apr_bucket *b = (apr_bucket *)malloc(sizeof(*b));
APR_BUCKET_INIT(b);
return apr_bucket_socket_make(b, p);
