jwoolley 2002/07/02 17:15:08
Modified: include apr_ring.h
include apr_buckets.h
Log:
Let's get rid of these damned things once and for all... for every line
of code they save, they seem to introduce two to three bugs. :)
Revision Changes Path
1.6 +4 -0 apr/include/apr_ring.h
Index: apr_ring.h
===================================================================
RCS file: /home/cvs/apr/include/apr_ring.h,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -d -u -r1.5 -r1.6
--- apr_ring.h 3 Jun 2002 21:24:23 -0000 1.5
+++ apr_ring.h 3 Jul 2002 00:15:07 -0000 1.6
@@ -404,6 +404,10 @@
* APR_RING_REMOVE(ep, link);
* }
* </pre>
+ * @deprecated This macro causes more headaches than it's worth. Use
+ * one of the alternatives documented here instead; the clarity gained
+ * in what's really going on is well worth the extra line or two of code.
+ * This macro will be removed at some point in the future.
*/
#define APR_RING_FOREACH(ep, hp, elem, link) \
for ((ep) = APR_RING_FIRST((hp));
\
1.143 +4 -0 apr-util/include/apr_buckets.h
Index: apr_buckets.h
===================================================================
RCS file: /home/cvs/apr-util/include/apr_buckets.h,v
retrieving revision 1.142
retrieving revision 1.143
diff -u -d -u -r1.142 -r1.143
--- apr_buckets.h 2 Jun 2002 20:17:52 -0000 1.142
+++ apr_buckets.h 3 Jul 2002 00:15:07 -0000 1.143
@@ -377,6 +377,10 @@
* apr_bucket_delete(e);
* }
* </pre>
+ * @deprecated This macro causes more headaches than it's worth. Use
+ * one of the alternatives documented here instead; the clarity gained
+ * in what's really going on is well worth the extra line or two of code.
+ * This macro will be removed at some point in the future.
*/
#define APR_BRIGADE_FOREACH(e, b) \
APR_RING_FOREACH((e), &(b)->list, apr_bucket, link)