cvs commit: cocoon-2.1/src/blocks/forms/java/org/apache/cocoon/forms/formmodel AbstractWidget.java

[mpo]

mpo         2004/04/22 02:41:49

  Modified:    src/blocks/forms/java/org/apache/cocoon/forms/formmodel
                        AbstractWidget.java
  Log:
  Fixing wrong logic introduced by previous commit.
  (plus more javadoc clarifications)
  
  Revision  Changes    Path
  1.11      +5 -5      
cocoon-2.1/src/blocks/forms/java/org/apache/cocoon/forms/formmodel/AbstractWidget.java
  
  Index: AbstractWidget.java
  ===================================================================
  RCS file: 
/home/cvs/cocoon-2.1/src/blocks/forms/java/org/apache/cocoon/forms/formmodel/AbstractWidget.java,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- AbstractWidget.java       22 Apr 2004 08:05:00 -0000      1.10
  +++ AbstractWidget.java       22 Apr 2004 09:41:49 -0000      1.11
  @@ -286,7 +286,7 @@
           AttributesImpl attrs = new AttributesImpl();
           // top-level widget-containers like forms will have their id set to 
""
           // for those the @id should not be included.
  -        if (getId().length() == 0) {
  +        if (getId().length() != 0) {
                attrs.addCDATAAttribute("id", getFullyQualifiedId());
           }
           return attrs;
  @@ -294,10 +294,10 @@
   
       /**
        * Delegates to the [EMAIL PROTECTED] #getDefinition()} of this widget 
to generate a common
  -     * set of 'display' data.
  +     * set of 'display' data. (i.e. help, label, hint,...)
        * 
        * Subclasses should override if the getDefinition can return 
<code>null</code>
  -     * to avoid NPE's
  +     * to avoid NPE's.
        * 
        * @param contentHandler where to send the SAX events to.
        * @throws SAXException
  @@ -319,7 +319,7 @@
        * 
        * <pre>
        * &lt;fi:[EMAIL PROTECTED] #getXMLElementName()} [EMAIL PROTECTED] 
#getXMLElementAttributes() &gt;
  -     *   [EMAIL PROTECTED] #generateDisplayData(ContentHandler)}
  +     *   [EMAIL PROTECTED] #generateDisplayData(ContentHandler)} (i.e. help, 
label, ...)
        * 
        *   [EMAIL PROTECTED] #generateItemSaxFragment(ContentHandler, Locale)}
        * &lt;/fi:[EMAIL PROTECTED] #getXMLElementName()} &gt;