cvs commit: cocoon-2.1/src/blocks/scratchpad/java/org/apache/cocoon/components/source/impl DelayRefresher.java

[haul]

haul        2004/04/25 13:01:36

  Modified:    
src/blocks/scratchpad/java/org/apache/cocoon/components/source/impl
                        DelayRefresher.java
  Log:
  add TODO comment
  
  Revision  Changes    Path
  1.6       +6 -1      
cocoon-2.1/src/blocks/scratchpad/java/org/apache/cocoon/components/source/impl/DelayRefresher.java
  
  Index: DelayRefresher.java
  ===================================================================
  RCS file: 
/home/cvs/cocoon-2.1/src/blocks/scratchpad/java/org/apache/cocoon/components/source/impl/DelayRefresher.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- DelayRefresher.java       15 Apr 2004 08:05:56 -0000      1.5
  +++ DelayRefresher.java       25 Apr 2004 20:01:36 -0000      1.6
  @@ -201,6 +201,11 @@
        */
       public void execute(String name) {
           if (this.changed && this.writeSource != null) {
  +             // TODO when an error occurs during write, we wouldn't try 
again although the
  +             // list is still dirty. In addition, the access through the 
Iterator is not
  +             // synchronized -- Collections.synchronizedMap() doesn't 
suffice here. Thus,
  +             // modifications to the collection of sources while writing 
them to a file 
  +             // ay result in undeterministic behaviour (quoting the javadocs)
               this.changed = false;
               try {
                   final OutputStream stream = ((ModifiableSource) 
this.writeSource).getOutputStream();