Author: cziegeler
Date: Mon Feb 14 06:49:32 2005
New Revision: 153794

URL: http://svn.apache.org/viewcvs?view=rev&rev=153794
Log:
Fix bug in GroupBasedProfileManager; make basket independent from used 
authentication method

Modified:
    
cocoon/branches/BRANCH_2_1_X/src/blocks/portal/java/org/apache/cocoon/portal/coplets/basket/BasketManagerImpl.java
    
cocoon/branches/BRANCH_2_1_X/src/blocks/portal/java/org/apache/cocoon/portal/profile/impl/GroupBasedProfileManager.java

Modified: 
cocoon/branches/BRANCH_2_1_X/src/blocks/portal/java/org/apache/cocoon/portal/coplets/basket/BasketManagerImpl.java
URL: 
http://svn.apache.org/viewcvs/cocoon/branches/BRANCH_2_1_X/src/blocks/portal/java/org/apache/cocoon/portal/coplets/basket/BasketManagerImpl.java?view=diff&r1=153793&r2=153794
==============================================================================
--- 
cocoon/branches/BRANCH_2_1_X/src/blocks/portal/java/org/apache/cocoon/portal/coplets/basket/BasketManagerImpl.java
 (original)
+++ 
cocoon/branches/BRANCH_2_1_X/src/blocks/portal/java/org/apache/cocoon/portal/coplets/basket/BasketManagerImpl.java
 Mon Feb 14 06:49:32 2005
@@ -72,8 +72,6 @@
 import org.apache.cocoon.servlet.multipart.Part;
 import org.apache.cocoon.servlet.multipart.PartOnDisk;
 import org.apache.cocoon.util.ClassUtils;
-import org.apache.cocoon.webapps.authentication.AuthenticationManager;
-import org.apache.cocoon.webapps.authentication.user.RequestState;
 import org.apache.excalibur.source.Source;
 import org.apache.excalibur.source.SourceResolver;
 
@@ -690,19 +688,18 @@
      * Get the current user
      */
     protected String getUser() {
-            AuthenticationManager authManager = null;
-            try {
-                authManager = 
(AuthenticationManager)this.manager.lookup(AuthenticationManager.ROLE);
-                RequestState rs = authManager.getState();
-            return rs.getHandler().getUserId();
-            } catch (ServiceException ignore) {
-                // ignore this
+        PortalService service = null;
+        try {
+            service = (PortalService)this.manager.lookup(PortalService.ROLE);
+            return 
service.getComponentManager().getProfileManager().getUser().getUserName();
+        } catch (ServiceException ignore) {
+            // ignore this
         } finally {
-            this.manager.release(authManager);
-            }
+            this.manager.release(service);
+        }
         return null;
         
-        }
+    }
     
     /* (non-Javadoc)
      * @see 
org.apache.cocoon.portal.coplets.basket.BasketManager#getBasketActions()

Modified: 
cocoon/branches/BRANCH_2_1_X/src/blocks/portal/java/org/apache/cocoon/portal/profile/impl/GroupBasedProfileManager.java
URL: 
http://svn.apache.org/viewcvs/cocoon/branches/BRANCH_2_1_X/src/blocks/portal/java/org/apache/cocoon/portal/profile/impl/GroupBasedProfileManager.java?view=diff&r1=153793&r2=153794
==============================================================================
--- 
cocoon/branches/BRANCH_2_1_X/src/blocks/portal/java/org/apache/cocoon/portal/profile/impl/GroupBasedProfileManager.java
 (original)
+++ 
cocoon/branches/BRANCH_2_1_X/src/blocks/portal/java/org/apache/cocoon/portal/profile/impl/GroupBasedProfileManager.java
 Mon Feb 14 06:49:32 2005
@@ -403,7 +403,7 @@
             
             // first "load" the global data
             profile.setCopletBaseDatas( this.getGlobalBaseDatas(loader, info, 
service) );
-            profile.setCopletDatas( this.getGlobalDatas(loader, info, service) 
);
+            profile.setCopletDatas( this.getGlobalDatas(loader, info, service, 
profile) );
             
             // now load the user/group specific data
             if ( !this.getCopletInstanceDatas(loader, profile, info, service, 
CATEGORY_USER) ) {
@@ -464,7 +464,8 @@
     
     protected Map getGlobalDatas(final ProfileLS     loader,
                                  final UserInfo      info,
-                                 final PortalService service) 
+                                 final PortalService service,
+                                 final UserProfile   profile) 
     throws Exception {
         synchronized ( this ) {
             final Map key = this.buildKey(CATEGORY_GLOBAL, 
@@ -474,6 +475,8 @@
             final Map parameters = new HashMap();
             parameters.put(ProfileLS.PARAMETER_PROFILETYPE, 
                            ProfileLS.PROFILETYPE_COPLETDATA);
+            parameters.put(ProfileLS.PARAMETER_OBJECTMAP,
+                           profile.getCopletBaseDatas());
             
             if ( this.copletDatas.validity != null
                  && this.copletDatas.validity.isValid() == 
SourceValidity.VALID) {
@@ -515,7 +518,7 @@
         Map parameters = new HashMap();
         parameters.put(ProfileLS.PARAMETER_PROFILETYPE, 
                        ProfileLS.PROFILETYPE_COPLETINSTANCEDATA);        
-        parameters.put(ProfileLS.PARAMETER_OBJECTMAP, 
+        parameters.put(ProfileLS.PARAMETER_OBJECTMAP,
                        profile.getCopletDatas());
 
         try {


Reply via email to