Author: toad
Date: 2008-12-03 12:50:17 +0000 (Wed, 03 Dec 2008)
New Revision: 24027

Modified:
   trunk/freenet/src/freenet/node/PacketTracker.java
Log:
Comments


Modified: trunk/freenet/src/freenet/node/PacketTracker.java
===================================================================
--- trunk/freenet/src/freenet/node/PacketTracker.java   2008-12-03 04:17:42 UTC 
(rev 24026)
+++ trunk/freenet/src/freenet/node/PacketTracker.java   2008-12-03 12:50:17 UTC 
(rev 24027)
@@ -497,6 +497,8 @@
         * haven't been sent yet.
         */
        public synchronized void acknowledgedPackets(int[] seqNos) {
+               // FIXME locking: can we just sync on the first part, and not 
the callbacks? 
+               // acknowledgedPacket() only sync's on removeAckRequest, but as 
mentioned above we need to do a bit more...
                AsyncMessageCallback[][] callbacks = new 
AsyncMessageCallback[seqNos.length][];
                for(int i = 0; i < seqNos.length; i++) {
                        int realSeqNo = seqNos[i];
@@ -971,7 +973,7 @@
        }
 
        /**
-        * Clear the KeyTracker. Depreciate it, clear all resend, ack, 
request-ack etc queues.
+        * Clear the KeyTracker. Deprecate it, clear all resend, ack, 
request-ack etc queues.
         * Return the messages we still had in flight. The caller will then 
either add them to
         * another KeyTracker, or call their callbacks to indicate failure.
         */

_______________________________________________
cvs mailing list
[email protected]
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/cvs

Reply via email to