Author: juiceman Date: 2008-12-29 21:31:20 +0000 (Mon, 29 Dec 2008) New Revision: 24827
Modified: trunk/freenet/src/freenet/client/DefaultMIMETypes.java trunk/freenet/src/freenet/io/comm/Message.java trunk/freenet/src/freenet/io/comm/MessageFilter.java Log: Findbugs 1.3.6 says since we are using Java 1.5 or higher we should use Short.valueOf() instead of new Short(). This seems to be the common wisdom on the Internet http://jkingdon2000.blogspot.com/2007/01/new-integer5-versus-integervalueof5.html Modified: trunk/freenet/src/freenet/client/DefaultMIMETypes.java =================================================================== --- trunk/freenet/src/freenet/client/DefaultMIMETypes.java 2008-12-29 17:12:33 UTC (rev 24826) +++ trunk/freenet/src/freenet/client/DefaultMIMETypes.java 2008-12-29 21:31:20 UTC (rev 24827) @@ -63,7 +63,7 @@ */ protected static synchronized void addMIMEType(short number, String type, String[] extensions, String outExtension) { addMIMEType(number, type); - Short t = new Short(number); + Short t = Short.valueOf(number); if(extensions != null) { for(int i=0;i<extensions.length;i++) { String ext = extensions[i].toLowerCase(); Modified: trunk/freenet/src/freenet/io/comm/Message.java =================================================================== --- trunk/freenet/src/freenet/io/comm/Message.java 2008-12-29 17:12:33 UTC (rev 24826) +++ trunk/freenet/src/freenet/io/comm/Message.java 2008-12-29 21:31:20 UTC (rev 24827) @@ -181,7 +181,7 @@ } public void set(String key, short s) { - set(key, new Short(s)); + set(key, Short.valueOf(s)); } public void set(String key, int i) { Modified: trunk/freenet/src/freenet/io/comm/MessageFilter.java =================================================================== --- trunk/freenet/src/freenet/io/comm/MessageFilter.java 2008-12-29 17:12:33 UTC (rev 24826) +++ trunk/freenet/src/freenet/io/comm/MessageFilter.java 2008-12-29 21:31:20 UTC (rev 24827) @@ -139,7 +139,7 @@ } public MessageFilter setField(String fieldName, short value) { - return setField(fieldName, new Short(value)); + return setField(fieldName, Short.valueOf(value)); } public MessageFilter setField(String fieldName, int value) { _______________________________________________ cvs mailing list [email protected] http://emu.freenetproject.org/cgi-bin/mailman/listinfo/cvs
