Author: toad
Date: 2009-01-10 20:29:25 +0000 (Sat, 10 Jan 2009)
New Revision: 25002

Modified:
   trunk/freenet/src/freenet/clients/http/ToadletContextImpl.java
Log:
Avoid a rare bucket leak. Comments.


Modified: trunk/freenet/src/freenet/clients/http/ToadletContextImpl.java
===================================================================
--- trunk/freenet/src/freenet/clients/http/ToadletContextImpl.java      
2009-01-10 20:28:39 UTC (rev 25001)
+++ trunk/freenet/src/freenet/clients/http/ToadletContextImpl.java      
2009-01-10 20:29:25 UTC (rev 25002)
@@ -441,7 +441,7 @@
                        return false;
                }
                String path = uri.getRawPath();
-               String secureid = req.getParam("secureid"); // remove it
+               String secureid = req.getParam("secureid");
                String queries = getQueriesNoSecureID(uri);
                String realPath = path;
                if(queries != null) realPath += queries;
@@ -450,6 +450,7 @@
                        expectedSecureID = ctx.container.generateSID(realPath);
                } catch (URLEncodedFormatException e1) {
                        ctx.sendError(400, "Bad Request", 
l10n("invalidURICheckingSecureID"), false, null);
+                       req.freeParts();
                        return true;
                }
                if(secureid != null && expectedSecureID.equals(secureid)) {

_______________________________________________
cvs mailing list
[email protected]
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/cvs

Reply via email to