Author: toad
Date: 2009-04-02 15:03:43 +0000 (Thu, 02 Apr 2009)
New Revision: 26350
Modified:
trunk/freenet/src/freenet/client/async/SingleFileInserter.java
Log:
Comments
Modified: trunk/freenet/src/freenet/client/async/SingleFileInserter.java
===================================================================
--- trunk/freenet/src/freenet/client/async/SingleFileInserter.java
2009-04-02 14:45:44 UTC (rev 26349)
+++ trunk/freenet/src/freenet/client/async/SingleFileInserter.java
2009-04-02 15:03:43 UTC (rev 26350)
@@ -847,6 +847,10 @@
if(oldMetadataPutter != null)
oldMetadataPutter.cancel(container, context);
+ // FIXME in the other cases, fail() and onSuccess(), we
only free when
+ // we set finished. But we haven't set finished here.
Can we rely on
+ // the callback and not do anything here? Note that it
is in fact safe
+ // to double-free, it's not safe to not free.
if(freeData) {
if(persistent)
container.activate(block, 2);
_______________________________________________
cvs mailing list
[email protected]
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/cvs
