Author: toad
Date: 2009-04-04 14:48:28 +0000 (Sat, 04 Apr 2009)
New Revision: 26525

Modified:
   trunk/freenet/src/freenet/support/io/BucketChainBucket.java
Log:
Actually we do have to free shadow buckets in some cases. Also trivial generics.


Modified: trunk/freenet/src/freenet/support/io/BucketChainBucket.java
===================================================================
--- trunk/freenet/src/freenet/support/io/BucketChainBucket.java 2009-04-04 
14:44:31 UTC (rev 26524)
+++ trunk/freenet/src/freenet/support/io/BucketChainBucket.java 2009-04-04 
14:48:28 UTC (rev 26525)
@@ -327,12 +327,13 @@
        }
 
        public Bucket createShadow() throws IOException {
-               Vector newBuckets = new Vector();
+               Vector<Bucket> newBuckets = new Vector<Bucket>();
                for(int i=0;i<buckets.size();i++) {
                        Bucket data = buckets.get(i);
                        Bucket shadow = data.createShadow();
                        if(shadow == null) {
-                               // Shadow buckets don't need to be freed.
+                               for(Bucket bucket : newBuckets)
+                                       bucket.free();
                                return null;
                        }
                        newBuckets.add(shadow);

_______________________________________________
cvs mailing list
[email protected]
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/cvs

Reply via email to