Author: zothar
Date: 2006-06-09 13:04:40 +0000 (Fri, 09 Jun 2006)
New Revision: 9094

Modified:
   trunk/freenet/src/freenet/node/PeerNode.java
Log:
Remove extra RANDOMIZEDs in sentHandshake() and couldNotSendHandshake() since 
handshakes should not be farther apart than 30 seconds because of UDP hole 
punching.  This also makes the two methods more similar.

Modified: trunk/freenet/src/freenet/node/PeerNode.java
===================================================================
--- trunk/freenet/src/freenet/node/PeerNode.java        2006-06-09 11:38:29 UTC 
(rev 9093)
+++ trunk/freenet/src/freenet/node/PeerNode.java        2006-06-09 13:04:40 UTC 
(rev 9094)
@@ -832,7 +832,6 @@
             if(verifiedIncompatibleOlderVersion || 
verifiedIncompatibleNewerVersion) { 
                 // Let them know we're here, but have no hope of connecting
                 sendHandshakeTime = now + Node.MIN_TIME_BETWEEN_VERSION_SENDS
-                  + 
node.random.nextInt(Node.RANDOMIZED_TIME_BETWEEN_VERSION_SENDS)
                   + 
node.random.nextInt(Node.RANDOMIZED_TIME_BETWEEN_VERSION_SENDS);
             } else if(invalidVersion() && !firstHandshake) {
                 sendHandshakeTime = now + Node.MIN_TIME_BETWEEN_VERSION_PROBES
@@ -873,15 +872,12 @@
             if(verifiedIncompatibleOlderVersion || 
verifiedIncompatibleNewerVersion) { 
                 // Let them know we're here, but have no hope of connecting
                 sendHandshakeTime = now + Node.MIN_TIME_BETWEEN_VERSION_SENDS
-                  + 
node.random.nextInt(Node.RANDOMIZED_TIME_BETWEEN_VERSION_SENDS)
                   + 
node.random.nextInt(Node.RANDOMIZED_TIME_BETWEEN_VERSION_SENDS);
             } else if(invalidVersion() && !firstHandshake) {
                 sendHandshakeTime = now + Node.MIN_TIME_BETWEEN_VERSION_PROBES
-                  + 
node.random.nextInt(Node.RANDOMIZED_TIME_BETWEEN_VERSION_PROBES)
                   + 
node.random.nextInt(Node.RANDOMIZED_TIME_BETWEEN_VERSION_PROBES);
             } else {
                 sendHandshakeTime = now + Node.MIN_TIME_BETWEEN_HANDSHAKE_SENDS
-                  + 
node.random.nextInt(Node.RANDOMIZED_TIME_BETWEEN_HANDSHAKE_SENDS)
                   + 
node.random.nextInt(Node.RANDOMIZED_TIME_BETWEEN_HANDSHAKE_SENDS);
             }
             handshakeIPs = null;


Reply via email to