[freenet-cvs] r16755 - trunk/freenet/src/freenet/node

[rob...@freenetproject.org]

Author: robert
Date: 2007-12-20 20:40:23 +0000 (Thu, 20 Dec 2007)
New Revision: 16755

Modified:
   trunk/freenet/src/freenet/node/InsertHandler.java
Log:
possibly winnable race condition receiveStarted/finish()


Modified: trunk/freenet/src/freenet/node/InsertHandler.java
===================================================================
--- trunk/freenet/src/freenet/node/InsertHandler.java   2007-12-20 20:17:52 UTC 
(rev 16754)
+++ trunk/freenet/src/freenet/node/InsertHandler.java   2007-12-20 20:40:23 UTC 
(rev 16755)
@@ -146,8 +146,8 @@
         br = new BlockReceiver(node.usm, source, uid, prb, this);

         // Receive the data, off thread
-        
         Runnable dataReceiver = new DataReceiver();
+               receiveStarted = true;
         node.executor.execute(dataReceiver, "InsertHandler$DataReceiver for 
UID "+uid);

         if(htl == 0) {
@@ -416,9 +416,6 @@

         public void run() {
                    freenet.support.Logger.OSThread.logPID(this);
-               synchronized(this) {
-                       receiveStarted = true;
-               }
                if(logMINOR) Logger.minor(this, "Receiving data for 
"+InsertHandler.this);
             try {
                 br.receive();