Author: toad
Date: 2007-12-22 15:13:08 +0000 (Sat, 22 Dec 2007)
New Revision: 16784

Modified:
   trunk/freenet/src/freenet/client/async/SingleFileInserter.java
Log:
Don't start inserting metadata in onFetchable().
If EarlyEncode, start it in onMetadata().
If not, start it in onSuccess().
Improves security: if the attacker doesn't know the file being inserted, then 
as soon as we insert the top block, he does know, and can actively move towards 
the originator as he receives new blocks.

Modified: trunk/freenet/src/freenet/client/async/SingleFileInserter.java
===================================================================
--- trunk/freenet/src/freenet/client/async/SingleFileInserter.java      
2007-12-22 15:10:22 UTC (rev 16783)
+++ trunk/freenet/src/freenet/client/async/SingleFileInserter.java      
2007-12-22 15:13:08 UTC (rev 16784)
@@ -644,8 +644,6 @@

                        if(meta)
                                cb.onFetchable(this);
-                       else
-                               startMetadata();
                }

                private void startMetadata() {


Reply via email to