Author: nextgens
Date: 2007-03-26 09:47:14 +0000 (Mon, 26 Mar 2007)
New Revision: 12381

Modified:
   trunk/freenet/src/freenet/clients/http/FProxyToadlet.java
Log:
Handle properly invalid referers (sending back to the home directory)
I'm not sure it's the intended behaviour either ... but logging at ERROR is 
excessive anyway.

Mar 25, 2007 01:41:27:913 (freenet.clients.http.FProxyToadlet, 
freenet.clients.http.SimpleToadletServer$SocketHandler at 5061e1, ERROR): 
Caught handling referrer: java.net.MalformedURLException for 
http://localhost:8889/queue/
java.net.MalformedURLException
        at freenet.keys.FreenetURI.<init>(FreenetURI.java:241)
        at 
freenet.clients.http.FProxyToadlet.sanitizeReferer(FProxyToadlet.java:533)
        at freenet.clients.http.FProxyToadlet.handleGet(FProxyToadlet.java:343)
        at 
freenet.clients.http.ToadletContextImpl.handle(ToadletContextImpl.java:295)
        at 
freenet.clients.http.SimpleToadletServer$SocketHandler.run(SimpleToadletServer.java:416)
        at java.lang.Thread.run(Thread.java:619)

Modified: trunk/freenet/src/freenet/clients/http/FProxyToadlet.java
===================================================================
--- trunk/freenet/src/freenet/clients/http/FProxyToadlet.java   2007-03-26 
01:09:40 UTC (rev 12380)
+++ trunk/freenet/src/freenet/clients/http/FProxyToadlet.java   2007-03-26 
09:47:14 UTC (rev 12381)
@@ -536,6 +536,9 @@
                                referer = "/" + furi.toString();
                                if(type != null && type.length() > 0)
                                        referer += "?type=" + type;
+                       } catch (MalformedURLException e) {
+                               referer = "/";
+                               Logger.normal(this, "Caught 
MalformedURLException on the referer : "+e.getMessage());
                        } catch (Throwable t) {
                                Logger.error(this, "Caught handling referrer: 
"+t+" for "+referer, t);
                                referer = null;


Reply via email to