Author: toad
Date: 2008-04-02 13:41:54 +0000 (Wed, 02 Apr 2008)
New Revision: 18914
Modified:
trunk/freenet/src/freenet/node/SendableRequest.java
Log:
comments: explain locking
Modified: trunk/freenet/src/freenet/node/SendableRequest.java
===================================================================
--- trunk/freenet/src/freenet/node/SendableRequest.java 2008-04-02 13:38:29 UTC
(rev 18913)
+++ trunk/freenet/src/freenet/node/SendableRequest.java 2008-04-02 13:41:54 UTC
(rev 18914)
@@ -8,6 +8,9 @@
/**
* A low-level request which can be sent immediately. These are registered
* on the ClientRequestScheduler.
+ * LOCKING: Because some subclasses may do wierd things like locking on an
external object
+ * (see e.g. SplitFileFetcherSubSegment), if we do take the lock we need to do
it last i.e.
+ * not call any subclass methods inside it.
*/
public abstract class SendableRequest implements RandomGrabArrayItem {
