Author: toad
Date: 2008-04-05 13:47:51 +0000 (Sat, 05 Apr 2008)
New Revision: 19026
Modified:
trunk/freenet/src/freenet/clients/http/ToadletContextImpl.java
Log:
ALWAYS call freeParts(). Avoids leaking bucket in GET, PUT (new), or in POST if
it throws a RedirectException (old).
Modified: trunk/freenet/src/freenet/clients/http/ToadletContextImpl.java
===================================================================
--- trunk/freenet/src/freenet/clients/http/ToadletContextImpl.java
2008-04-05 13:46:59 UTC (rev 19025)
+++ trunk/freenet/src/freenet/clients/http/ToadletContextImpl.java
2008-04-05 13:47:51 UTC (rev 19026)
@@ -349,7 +349,6 @@
} else if(method.equals("POST")) {
t.handlePost(uri, req,
ctx);
- req.freeParts();
} else {
ctx.sendMethodNotAllowed(method, ctx.shouldDisconnect);
@@ -358,6 +357,8 @@
} catch (RedirectException re) {
uri = re.newuri;
redirect = true;
+ } finally {
+ req.freeParts();
}
}
if(ctx.shouldDisconnect) {
