Author: toad
Date: 2008-04-19 15:29:27 +0000 (Sat, 19 Apr 2008)
New Revision: 19419
Modified:
trunk/freenet/src/freenet/node/IPDetectorPluginManager.java
Log:
Explain decision to not nag the user to forward ports which are
MAYBE_PORT_FORWARDED
Modified: trunk/freenet/src/freenet/node/IPDetectorPluginManager.java
===================================================================
--- trunk/freenet/src/freenet/node/IPDetectorPluginManager.java 2008-04-19
15:22:28 UTC (rev 19418)
+++ trunk/freenet/src/freenet/node/IPDetectorPluginManager.java 2008-04-19
15:29:27 UTC (rev 19419)
@@ -136,11 +136,15 @@
false, UserAlert.MINOR, false);
}
+ /**
+ * Use MAYBE_PORT_FORWARDED as the threshold, because most people
either are behind a NAT with
+ * a low timeout (e.g. a home router), know what they're doing, or
can't forward ports anyway.
+ */
public int[] getUDPPortsNotForwarded() {
OpennetManager om = node.getOpennet();
int darknetStatus =
node.darknetCrypto.getDetectedConnectivityStatus();
int opennetStatus = om == null ? AddressTracker.DONT_KNOW :
om.crypto.getDetectedConnectivityStatus();
- if(om == null || opennetStatus ==
AddressTracker.DEFINITELY_PORT_FORWARDED) {
+ if(om == null || opennetStatus > AddressTracker.DONT_KNOW) {
if(darknetStatus > AddressTracker.DONT_KNOW) {
return new int[] { };
} else {
