Author: toad
Date: 2008-08-28 23:26:20 +0000 (Thu, 28 Aug 2008)
New Revision: 22207
Modified:
branches/db4o/freenet/src/freenet/client/async/ClientRequestSchedulerCore.java
Log:
Clarify comment
Modified:
branches/db4o/freenet/src/freenet/client/async/ClientRequestSchedulerCore.java
===================================================================
---
branches/db4o/freenet/src/freenet/client/async/ClientRequestSchedulerCore.java
2008-08-28 23:24:33 UTC (rev 22206)
+++
branches/db4o/freenet/src/freenet/client/async/ClientRequestSchedulerCore.java
2008-08-28 23:26:20 UTC (rev 22207)
@@ -452,9 +452,14 @@
// Check recentSuccesses
/** FIXME:
* This does not make sense with selecting a whole
SendableRequest
- * at a time, so turn it off. However, what would make
sense would
- * be to have recentSuccesses be a list of
ClientRequester's instead,
- * like we do on trunk. */
+ * at a time (for persistent requests), so turn it off.
However,
+ * what would make sense would be to have
recentSuccesses be a list
+ * of ClientRequester's instead. This should improve
efficiency.
+ * We could make it transient even for persistent
requests, although
+ * we'd probably get better results if it wasn't. We
cannot use the
+ * Db4o built-in deprecated activation aware
collections, because
+ * they reactivate deactivated data in their commit
hooks and thus
+ * cause serious problems. */
if(!req.persistent()) {
List recent = schedTransient.recentSuccesses;
SendableRequest altReq = null;
