Author: toad
Date: 2008-02-22 22:26:53 +0000 (Fri, 22 Feb 2008)
New Revision: 18112

Modified:
   trunk/freenet/src/freenet/node/PeerNode.java
Log:
Fix "Received packet while disconnected!"

Modified: trunk/freenet/src/freenet/node/PeerNode.java
===================================================================
--- trunk/freenet/src/freenet/node/PeerNode.java        2008-02-22 21:57:23 UTC 
(rev 18111)
+++ trunk/freenet/src/freenet/node/PeerNode.java        2008-02-22 22:26:53 UTC 
(rev 18112)
@@ -1665,7 +1665,11 @@
        void receivedPacket(boolean dontLog) {
                synchronized(this) {
                        if((!isConnected) && (!dontLog)) {
-                               if((unverifiedTracker == null) && 
(currentTracker == null))
+                               // Don't log if we are disconnecting, because 
receiving packets during disconnecting is normal.
+                               // That includes receiving packets after we 
have technically disconnected already.
+                               // A race condition involving 
forceCancelDisconnecting causing a mistaken log message anyway 
+                               // is conceivable, but unlikely...
+                               if((unverifiedTracker == null) && 
(currentTracker == null) && !disconnecting)
                                        Logger.error(this, "Received packet 
while disconnected!: " + this, new Exception("error"));
                                else
                                        if(logMINOR)


Reply via email to