Author: robert
Date: 2008-01-04 02:36:37 +0000 (Fri, 04 Jan 2008)
New Revision: 16873

Modified:
   trunk/freenet/src/freenet/node/PacketSender.java
Log:
comment confusing conditional


Modified: trunk/freenet/src/freenet/node/PacketSender.java
===================================================================
--- trunk/freenet/src/freenet/node/PacketSender.java    2008-01-04 02:10:13 UTC 
(rev 16872)
+++ trunk/freenet/src/freenet/node/PacketSender.java    2008-01-04 02:36:37 UTC 
(rev 16873)
@@ -201,7 +201,12 @@
                                        pn.disconnected(false, false /* 
hopefully will recover, transient network glitch */);
                                        continue;
                                } else if(pn.isRoutable() && 
pn.noLongerRoutable()) {
-                                       // we don't disconnect but we mark it 
incompatible
+                                       /*
+                                        NOTE: Whereas isRoutable() && 
noLongerRoutable() are generally mutually exclusive, this
+                                        code will only execute because of the 
scheduled-runnable in start() which executes
+                                        updateVersionRoutablity() on all our 
peers. We don't disconnect the peer, but mark it
+                                        as being incompatible.
+                                        */
                                        pn.invalidate();
                                        pn.setPeerNodeStatus(now);
                                        Logger.normal(this, 
"shouldDisconnectNow has returned true : marking the peer as incompatible");


Reply via email to