Author: toad
Date: 2008-06-28 20:43:09 +0000 (Sat, 28 Jun 2008)
New Revision: 20859

Modified:
   branches/db4o/freenet/src/freenet/client/async/SplitFileFetcherSegment.java
Log:
Logging

Modified: 
branches/db4o/freenet/src/freenet/client/async/SplitFileFetcherSegment.java
===================================================================
--- branches/db4o/freenet/src/freenet/client/async/SplitFileFetcherSegment.java 
2008-06-28 18:50:40 UTC (rev 20858)
+++ branches/db4o/freenet/src/freenet/client/async/SplitFileFetcherSegment.java 
2008-06-28 20:43:09 UTC (rev 20859)
@@ -181,7 +181,13 @@
                boolean dontNotify;
                synchronized(this) {
                        if(finished) {
-                               Logger.error(this, "onSuccess() when already 
finished");
+                               // Happens sometimes, don't complain about it...
+                               // What this means is simply that there were a 
bunch of requests
+                               // running, one of them completed, the whole 
segment went into
+                               // decode, and now the extra requests are 
surplus to requirements.
+                               // It's a slight overhead, but the alternative 
is worse.
+                               if(logMINOR)
+                                       Logger.minor(this, "onSuccess() when 
already finished for "+this);
                                return;
                        }
                        if(blockNo < dataKeys.length) {


Reply via email to