[freenet-cvs] r18468 - trunk/freenet/src/freenet/node

[t...@freenetproject.org]

Author: toad
Date: 2008-03-11 17:54:07 +0000 (Tue, 11 Mar 2008)
New Revision: 18468

Modified:
   trunk/freenet/src/freenet/node/KeyTracker.java
Log:
Comments

Modified: trunk/freenet/src/freenet/node/KeyTracker.java
===================================================================
--- trunk/freenet/src/freenet/node/KeyTracker.java      2008-03-11 17:36:44 UTC 
(rev 18467)
+++ trunk/freenet/src/freenet/node/KeyTracker.java      2008-03-11 17:54:07 UTC 
(rev 18468)
@@ -533,6 +533,10 @@
      */
     private void queueAckRequest(int packetNumber) throws 
UpdatableSortedLinkedListKilledException {
         synchronized(ackRequestQueue) {
+               // FIXME should we just remove the existing ack request? If we 
do, we get a better
+               // estimate of RTT on lossy links... if we don't, lossy links 
will include the average
+               // time to send a packet including all resends. The latter may 
be useful, and in fact
+               // the former is unreliable...
             if(queuedAckRequest(packetNumber)) {
                if(logMINOR) Logger.minor(this, "Not queueing ack request for 
"+packetNumber+" - already queued");
                 return;