[freenet-cvs] r20100 - trunk/freenet/src/freenet/node

[j16s...@freenetproject.org]

Author: j16sdiz
Date: 2008-05-27 11:24:05 +0000 (Tue, 27 May 2008)
New Revision: 20100

Modified:
   trunk/freenet/src/freenet/node/Node.java
Log:
Comment


Modified: trunk/freenet/src/freenet/node/Node.java
===================================================================
--- trunk/freenet/src/freenet/node/Node.java    2008-05-27 07:01:28 UTC (rev 
20099)
+++ trunk/freenet/src/freenet/node/Node.java    2008-05-27 11:24:05 UTC (rev 
20100)
@@ -2605,6 +2605,8 @@
                synchronized(cachedPubKeys) {
                        DSAPublicKey key2 = (DSAPublicKey) cachedPubKeys.get(w);
                        if((key2 != null) && !key2.equals(key)) {
+                               // FIXME is this test really needed?
+                               // SHA-256 inside synchronized{} is a bad idea
                                MessageDigest md256 = SHA256.getMessageDigest();
                                try {
                                byte[] hashCheck = md256.digest(key.asBytes());