Update of 
/var/cvs/contributions/didactor2/src/portalpages/java/nl/didactor/component/portalpages
In directory 
james.mmbase.org:/tmp/cvs-serv26266/nl/didactor/component/portalpages

Modified Files:
        DidactorPortalPages.java 
Log Message:
Of course nothing is javadocced by our slavic friends, but coming to read the 
method 'initRelations' I think I understand that it is rather silly


See also: 
http://cvs.mmbase.org/viewcvs/contributions/didactor2/src/portalpages/java/nl/didactor/component/portalpages


Index: DidactorPortalPages.java
===================================================================
RCS file: 
/var/cvs/contributions/didactor2/src/portalpages/java/nl/didactor/component/portalpages/DidactorPortalPages.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -b -r1.5 -r1.6
--- DidactorPortalPages.java    21 Jan 2008 14:48:22 -0000      1.5
+++ DidactorPortalPages.java    21 Jan 2008 14:52:41 -0000      1.6
@@ -24,7 +24,8 @@
 
     public String getVersion() {
         return "0.1";
-    } /**
+    }
+    /**
      * Returns the name of the component
      */
     public String getName() {
@@ -55,11 +56,17 @@
         try{
         initRelations();
       } catch (Exception ex) {
-         ex.printStackTrace();
+            log.warn(ex);
       }
     }
 
-    public void initRelations() {
+    /**
+     * I think this method is a giant WTF, and what it tries to do already 
happens in a few lines
+     * in DidactorPortalPages.xml.
+
+     * WTF WTF WTF TODO TODO
+     */
+    protected void initRelations() {
         org.mmbase.module.core.MMBase mmb = (org.mmbase.module.core.MMBase) 
org.mmbase.module.Module.getModule("mmbaseroot");
         String username = "system";
         RelDef reldef = mmb.getRelDef();
@@ -72,6 +79,7 @@
         int portalpagescontainers = 
typedef.getIntValue("portalpagescontainers");
         int images = typedef.getIntValue("images");
 
+
         MMObjectBuilder portalcontainers = 
mmb.getBuilder("portalpagescontainers");
         try{
             if(portalcontainers.count(new NodeSearchQuery(portalcontainers)) < 
1){
@@ -128,35 +136,4 @@
 
     }
 
-    /**
-     *
-     */
-    /*
-    private boolean createClass(MMObjectNode cls) {
-        MMBase mmb = cls.getBuilder().getMMBase();
-
-        String classname = cls.getStringValue("name");
-        String username = "system";
-
-        MMObjectBuilder chatchannels = mmb.getBuilder("chatchannels");
-        InsRel insrel = mmb.getInsRel();
-        int related = mmb.getRelDef().getNumberByName("related");
-
-        MMObjectNode chatchannel = chatchannels.getNewNode(username);
-        String chatchannelName = classname.replaceAll(" ","-").toLowerCase();
-
-        chatchannel.setValue("name", chatchannelName);
-        chatchannels.insert(username, chatchannel);
-
-        MMObjectNode relation = insrel.getNewNode(username);
-
-        relation.setValue("snumber", cls.getNumber());
-        relation.setValue("dnumber", chatchannel.getNumber());
-        relation.setValue("rnumber", related);
-
-        insrel.insert(username, relation);
-
-        return true;
-    }
-   */
 }
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs

Reply via email to