Update of /var/cvs/html/mmbase/errorpages
In directory james.mmbase.org:/tmp/cvs-serv28573

Modified Files:
      Tag: MMBase-1_8
        500.jsp 
Log Message:
with very long stacktraces the performace of this page could be very lousy. 
This makes it a bit better


See also: http://cvs.mmbase.org/viewcvs/html/mmbase/errorpages


Index: 500.jsp
===================================================================
RCS file: /var/cvs/html/mmbase/errorpages/500.jsp,v
retrieving revision 1.8.2.2
retrieving revision 1.8.2.3
diff -u -b -r1.8.2.2 -r1.8.2.3
--- 500.jsp     25 May 2007 10:29:17 -0000      1.8.2.2
+++ 500.jsp     3 Mar 2008 12:36:24 -0000       1.8.2.3
@@ -17,6 +17,7 @@
 // prepare error details
 String title = null;
 StringBuffer msg = new StringBuffer();
+StringBuffer ex = new StringBuffer();
 {
     java.util.Stack stack = new java.util.Stack();
 
@@ -88,10 +89,10 @@
                  title = 
t.getClass().getName().substring(t.getClass().getPackage().getName().length() + 
1) + " " + el.getFileName() + ":" + el.getLineNumber();
                 }
             }
-       msg.append(message).append("\n");
-       msg.append(org.mmbase.util.logging.Logging.stackTrace(t));
+       ex.append(message).append("\n");
+       ex.append(org.mmbase.util.logging.Logging.stackTrace(t));
        if (! stack.isEmpty()) {
-          msg.append("\n-------caused:\n");
+          ex.append("\n-------caused:\n");
        }  
 
          }
@@ -101,11 +102,11 @@
 
 // write errors to mmbase log
 if (status == 500) {
-  log.error(ticket + ":\n" + msg);
+//  log.error(ticket + ":\n" + msg);
 }
 
 %>
-<mm:content type="text/html"  expires="0">
+<mm:content type="text/html"  postprocessor="none" expires="0">
 <html>
 <head>
   <mm:import id="title">MMBase - Error <%= status %></mm:import>
@@ -136,8 +137,10 @@
   </div>
   <div id="error" style="background-color:yellow; display: none;">
     <a href="javascript:hide();">Hide error</a>
-    <mm:import id="msg"> <%=msg.toString()%></mm:import>
+    <mm:import id="msg" escape="none"> <%=msg.toString()%></mm:import>
     <mm:write referid="msg" escape="p" />
+    <mm:import id="exceptionMsg" escape="none"> <%=ex.toString()%></mm:import>
+    <mm:write referid="exceptionMsg" escape="none" />
   </div>
   
   <hr />
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs

Reply via email to