Update of
/var/cvs/contributions/CMSContainer_Portlets/portlets-banner/src/java/com/finalist/portlets/banner
In directory
james.mmbase.org:/tmp/cvs-serv25057/portlets-banner/src/java/com/finalist/portlets/banner
Modified Files:
Tag: b1_4
BannerPortlet.java
Log Message:
CMSC-844 BannerPortlet has performance issues when the user visits the page
See also:
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer_Portlets/portlets-banner/src/java/com/finalist/portlets/banner
See also: http://www.mmbase.org/jira/browse/CMSC-844
Index: BannerPortlet.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer_Portlets/portlets-banner/src/java/com/finalist/portlets/banner/BannerPortlet.java,v
retrieving revision 1.6.2.2
retrieving revision 1.6.2.3
diff -u -b -r1.6.2.2 -r1.6.2.3
--- BannerPortlet.java 13 Mar 2008 10:50:25 -0000 1.6.2.2
+++ BannerPortlet.java 31 Mar 2008 09:20:06 -0000 1.6.2.3
@@ -98,9 +98,6 @@
&& (counter.getIntValue("clicks") >=
banner.getIntValue("maxclicks"))) {
log.debug("Maximum number of clicks reached for
banner: " + banner.getNumber() + ", skipping it");
iter.remove();
- } else {
- counter.setDateValue("enddate", now);
- counter.commit();
}
} else {
counter = createBannerCounter(cloud, banner, page,
position);
@@ -137,7 +134,10 @@
getLogger().debug("Could not find counter for banner: " +
bannerId + ", created a new one");
}
int clicks = counter.getIntValue("clicks") + 1;
+ Date now = new Date();
counter.setIntValue("clicks", clicks);
+ counter.setDateValue("enddate", now);
+
counter.commit();
getLogger().debug("Clicks updated to: " + clicks + " for banner: "
+ bannerId);
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs
