Update of
/var/cvs/contributions/CMSContainer_Modules/workflow/src/java/com/finalist/cmsc/workflow
In directory
james.mmbase.org:/tmp/cvs-serv30319/workflow/src/java/com/finalist/cmsc/workflow
Modified Files:
WorkflowManager.java LinkWorkflow.java ContentWorkflow.java
PageWorkflow.java
Log Message:
CMSC-907 Code Quality with PMD
Add final modifier to Util classes
Add final modifier to Logger instances
Change Boolean, Integer and Long instantiation to valueOf calls
See also:
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer_Modules/workflow/src/java/com/finalist/cmsc/workflow
See also: http://www.mmbase.org/jira/browse/CMSC-907
Index: WorkflowManager.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer_Modules/workflow/src/java/com/finalist/cmsc/workflow/WorkflowManager.java,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -b -r1.11 -r1.12
--- WorkflowManager.java 10 May 2008 16:31:49 -0000 1.11
+++ WorkflowManager.java 16 May 2008 11:45:45 -0000 1.12
@@ -21,7 +21,7 @@
public abstract class WorkflowManager {
/** MMbase logging system */
- private static Logger log =
Logging.getLoggerInstance(WorkflowManager.class.getName());
+ private static final Logger log =
Logging.getLoggerInstance(WorkflowManager.class.getName());
protected static final String SOURCE = "SOURCE";
protected static final String DESTINATION = "DESTINATION";
Index: LinkWorkflow.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer_Modules/workflow/src/java/com/finalist/cmsc/workflow/LinkWorkflow.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -b -r1.8 -r1.9
--- LinkWorkflow.java 14 Mar 2008 12:52:47 -0000 1.8
+++ LinkWorkflow.java 16 May 2008 11:45:45 -0000 1.9
@@ -27,7 +27,7 @@
public class LinkWorkflow extends RepositoryWorkflow {
/** MMbase logging system */
- private static Logger log =
Logging.getLoggerInstance(LinkWorkflow.class.getName());
+ private static final Logger log =
Logging.getLoggerInstance(LinkWorkflow.class.getName());
public static final String TYPE_LINK = "link";
Index: ContentWorkflow.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer_Modules/workflow/src/java/com/finalist/cmsc/workflow/ContentWorkflow.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -b -r1.6 -r1.7
--- ContentWorkflow.java 26 Nov 2007 11:42:14 -0000 1.6
+++ ContentWorkflow.java 16 May 2008 11:45:45 -0000 1.7
@@ -27,7 +27,7 @@
public class ContentWorkflow extends RepositoryWorkflow {
/** MMbase logging system */
- private static Logger log =
Logging.getLoggerInstance(ContentWorkflow.class.getName());
+ private static final Logger log =
Logging.getLoggerInstance(ContentWorkflow.class.getName());
public static final String TYPE_CONTENT = "content";
Index: PageWorkflow.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer_Modules/workflow/src/java/com/finalist/cmsc/workflow/PageWorkflow.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -b -r1.7 -r1.8
--- PageWorkflow.java 12 Apr 2008 14:26:33 -0000 1.7
+++ PageWorkflow.java 16 May 2008 11:45:45 -0000 1.8
@@ -30,7 +30,7 @@
public class PageWorkflow extends WorkflowManager {
/** MMbase logging system */
- private static Logger log =
Logging.getLoggerInstance(PageWorkflow.class.getName());
+ private static final Logger log =
Logging.getLoggerInstance(PageWorkflow.class.getName());
public static final String TYPE_PAGE = "page";
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs
