Update of
/var/cvs/contributions/CMSContainer_Modules/dataconversion/src/java/com/finalist/cmsc/dataconversion/dataaccess
In directory
james.mmbase.org:/tmp/cvs-serv30319/dataconversion/src/java/com/finalist/cmsc/dataconversion/dataaccess
Modified Files:
DataSourceFactory.java DataAccessor.java
Log Message:
CMSC-907 Code Quality with PMD
Add final modifier to Util classes
Add final modifier to Logger instances
Change Boolean, Integer and Long instantiation to valueOf calls
See also:
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer_Modules/dataconversion/src/java/com/finalist/cmsc/dataconversion/dataaccess
See also: http://www.mmbase.org/jira/browse/CMSC-907
Index: DataSourceFactory.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer_Modules/dataconversion/src/java/com/finalist/cmsc/dataconversion/dataaccess/DataSourceFactory.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -b -r1.1 -r1.2
--- DataSourceFactory.java 6 May 2008 11:05:49 -0000 1.1
+++ DataSourceFactory.java 16 May 2008 11:45:45 -0000 1.2
@@ -17,7 +17,7 @@
*/
public class DataSourceFactory {
- private static Logger log =
Logging.getLoggerInstance(DataSourceFactory.class.getName());
+ private static final Logger log =
Logging.getLoggerInstance(DataSourceFactory.class.getName());
public static DataSource getDataSource(Properties properties) {
Index: DataAccessor.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer_Modules/dataconversion/src/java/com/finalist/cmsc/dataconversion/dataaccess/DataAccessor.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -b -r1.1 -r1.2
--- DataAccessor.java 6 May 2008 11:05:49 -0000 1.1
+++ DataAccessor.java 16 May 2008 11:45:45 -0000 1.2
@@ -21,7 +21,7 @@
*/
public class DataAccessor {
- private static Logger log =
Logging.getLoggerInstance(DataAccessor.class.getName());
+ private static final Logger log =
Logging.getLoggerInstance(DataAccessor.class.getName());
private DataSource dataSource;
private ElementMeta elementMeta;
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs