Update of
/var/cvs/contributions/CMSContainer_Portlets/portlets-guestbook/src/java/com/finalist/captcha
In directory
james.mmbase.org:/tmp/cvs-serv30657/portlets-guestbook/src/java/com/finalist/captcha
Modified Files:
NumberListImageCaptchaEngine.java
Log Message:
CMSC-907 Code Quality with PMD
Add final modifier to Util classes
Add final modifier to Logger instances
Change Boolean, Integer and Long instantiation to valueOf calls
See also:
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer_Portlets/portlets-guestbook/src/java/com/finalist/captcha
See also: http://www.mmbase.org/jira/browse/CMSC-907
Index: NumberListImageCaptchaEngine.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer_Portlets/portlets-guestbook/src/java/com/finalist/captcha/NumberListImageCaptchaEngine.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -b -r1.2 -r1.3
--- NumberListImageCaptchaEngine.java 26 Nov 2007 11:42:56 -0000 1.2
+++ NumberListImageCaptchaEngine.java 16 May 2008 11:46:10 -0000 1.3
@@ -19,10 +19,10 @@
protected void buildInitialFactories() {
WordGenerator wordGenerator = new RandomWordGenerator("0123456789");
- TextPaster textPaster = new RandomTextPaster(new Integer(5), new
Integer(6), Color.BLACK);
- BackgroundGenerator backgroundGenerator = new
GradientBackgroundGenerator(new Integer(180), new Integer(40),
+ TextPaster textPaster = new RandomTextPaster(Integer.valueOf(5),
Integer.valueOf(6), Color.BLACK);
+ BackgroundGenerator backgroundGenerator = new
GradientBackgroundGenerator(Integer.valueOf(180), Integer.valueOf(40),
Color.GRAY, Color.WHITE);
- FontGenerator fontGenerator = new
TwistedAndShearedRandomFontGenerator(new Integer(16), new Integer(22));
+ FontGenerator fontGenerator = new
TwistedAndShearedRandomFontGenerator(Integer.valueOf(16), Integer.valueOf(22));
WordToImage wordToImage = new ComposedWordToImage(fontGenerator,
backgroundGenerator, textPaster);
this.addFactory(new GimpyFactory(wordGenerator, wordToImage));
}
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs
