Update of
/var/cvs/contributions/CMSContainer/cmsc/sitemanagement/src/java/com/finalist/cmsc/beans/om
In directory
james.mmbase.org:/tmp/cvs-serv30736/cmsc/sitemanagement/src/java/com/finalist/cmsc/beans/om
Modified Files:
Portlet.java Layout.java Page.java
Log Message:
CMSC-907 Code Quality with PMD
Add final modifier to Util classes
Add final modifier to Logger instances
Change Boolean, Integer and Long instantiation to valueOf calls
See also:
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer/cmsc/sitemanagement/src/java/com/finalist/cmsc/beans/om
See also: http://www.mmbase.org/jira/browse/CMSC-907
Index: Portlet.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer/cmsc/sitemanagement/src/java/com/finalist/cmsc/beans/om/Portlet.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -b -r1.6 -r1.7
--- Portlet.java 12 Apr 2008 14:26:07 -0000 1.6
+++ Portlet.java 16 May 2008 11:46:32 -0000 1.7
@@ -48,7 +48,7 @@
public void addView(int view) {
- this.views.add(new Integer(view));
+ this.views.add(Integer.valueOf(view));
}
Index: Layout.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer/cmsc/sitemanagement/src/java/com/finalist/cmsc/beans/om/Layout.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -b -r1.4 -r1.5
--- Layout.java 26 Nov 2007 11:43:41 -0000 1.4
+++ Layout.java 16 May 2008 11:46:32 -0000 1.5
@@ -71,7 +71,7 @@
definitions = new ArrayList<Integer>();
allowedDefinitions.put(name, definitions);
}
- Integer nr = new Integer(number);
+ Integer nr = Integer.valueOf(number);
if (!definitions.contains(nr)) {
definitions.add(nr);
}
Index: Page.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer/cmsc/sitemanagement/src/java/com/finalist/cmsc/beans/om/Page.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -b -r1.9 -r1.10
--- Page.java 16 Jan 2008 10:56:09 -0000 1.9
+++ Page.java 16 May 2008 11:46:32 -0000 1.10
@@ -41,7 +41,7 @@
public void addStylesheet(int stylesheet) {
- this.stylesheet.add(new Integer(stylesheet));
+ this.stylesheet.add(Integer.valueOf(stylesheet));
}
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs
