Update of
/var/cvs/contributions/CMSContainer/cmsc/security/src/java/com/finalist/cmsc/security/forms
In directory
james.mmbase.org:/tmp/cvs-serv30736/cmsc/security/src/java/com/finalist/cmsc/security/forms
Modified Files:
ChangeLanguageAction.java RolesForm.java
ChangePasswordAction.java RolesRenderer.java RolesInfo.java
Log Message:
CMSC-907 Code Quality with PMD
Add final modifier to Util classes
Add final modifier to Logger instances
Change Boolean, Integer and Long instantiation to valueOf calls
See also:
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer/cmsc/security/src/java/com/finalist/cmsc/security/forms
See also: http://www.mmbase.org/jira/browse/CMSC-907
Index: ChangeLanguageAction.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer/cmsc/security/src/java/com/finalist/cmsc/security/forms/ChangeLanguageAction.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -b -r1.4 -r1.5
--- ChangeLanguageAction.java 26 Nov 2007 11:43:43 -0000 1.4
+++ ChangeLanguageAction.java 16 May 2008 11:46:32 -0000 1.5
@@ -22,7 +22,7 @@
public class ChangeLanguageAction extends MMBaseAction {
/** MMbase logging system */
- private static transient Logger log =
Logging.getLoggerInstance(ChangeLanguageAction.class.getName());
+ private static final Logger log =
Logging.getLoggerInstance(ChangeLanguageAction.class.getName());
/**
Index: RolesForm.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer/cmsc/security/src/java/com/finalist/cmsc/security/forms/RolesForm.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -b -r1.3 -r1.4
--- RolesForm.java 26 Nov 2007 11:43:43 -0000 1.3
+++ RolesForm.java 16 May 2008 11:46:32 -0000 1.4
@@ -41,12 +41,12 @@
public UserRole getRole(int number) {
- return roles.get(new Integer(number));
+ return roles.get(Integer.valueOf(number));
}
public void addRole(int number, UserRole role) {
- roles.put(new Integer(number), role);
+ roles.put(Integer.valueOf(number), role);
}
Index: ChangePasswordAction.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer/cmsc/security/src/java/com/finalist/cmsc/security/forms/ChangePasswordAction.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -b -r1.5 -r1.6
--- ChangePasswordAction.java 26 Nov 2007 11:43:43 -0000 1.5
+++ ChangePasswordAction.java 16 May 2008 11:46:32 -0000 1.6
@@ -22,7 +22,7 @@
public class ChangePasswordAction extends MMBaseAction {
/** MMbase logging system */
- private static transient Logger log =
Logging.getLoggerInstance(ChangePasswordAction.class.getName());
+ private static final Logger log =
Logging.getLoggerInstance(ChangePasswordAction.class.getName());
/**
Index: RolesRenderer.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer/cmsc/security/src/java/com/finalist/cmsc/security/forms/RolesRenderer.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -b -r1.4 -r1.5
--- RolesRenderer.java 14 Dec 2007 14:09:12 -0000 1.4
+++ RolesRenderer.java 16 May 2008 11:46:32 -0000 1.5
@@ -6,7 +6,7 @@
import org.mmbase.bridge.Node;
import com.finalist.cmsc.security.UserRole;
-import com.finalist.tree.*;
+import com.finalist.tree.TreeModel;
import com.finalist.tree.html.HTMLTreeCellRenderer;
import com.finalist.tree.html.HTMLTreeElement;
@@ -28,7 +28,7 @@
this.user = cloud.getNode(form.getId());
}
else {
- throw new RuntimeException("What is the user node? nodenumber is
missing in UserForm for roles");
+ throw new IllegalStateException("What is the user node? nodenumber is
missing in UserForm for roles");
}
}
Index: RolesInfo.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer/cmsc/security/src/java/com/finalist/cmsc/security/forms/RolesInfo.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -b -r1.2 -r1.3
--- RolesInfo.java 26 Nov 2007 11:43:43 -0000 1.2
+++ RolesInfo.java 16 May 2008 11:46:32 -0000 1.3
@@ -47,7 +47,7 @@
}
if (openChannels.contains(number)) {
- openChannels.remove(new Integer(number));
+ openChannels.remove(Integer.valueOf(number));
}
}
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs
