Update of
/var/cvs/contributions/CMSContainer/cmsc/utilities/src/java/com/finalist/cmsc/mmbase
In directory
james.mmbase.org:/tmp/cvs-serv30736/cmsc/utilities/src/java/com/finalist/cmsc/mmbase
Modified Files:
TreePathCache.java PropertiesUtil.java TypeUtil.java
TreeUtil.java
Log Message:
CMSC-907 Code Quality with PMD
Add final modifier to Util classes
Add final modifier to Logger instances
Change Boolean, Integer and Long instantiation to valueOf calls
See also:
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer/cmsc/utilities/src/java/com/finalist/cmsc/mmbase
See also: http://www.mmbase.org/jira/browse/CMSC-907
Index: TreePathCache.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer/cmsc/utilities/src/java/com/finalist/cmsc/mmbase/TreePathCache.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -b -r1.5 -r1.6
--- TreePathCache.java 30 Nov 2007 10:58:31 -0000 1.5
+++ TreePathCache.java 16 May 2008 11:46:32 -0000 1.6
@@ -9,16 +9,12 @@
*/
package com.finalist.cmsc.mmbase;
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.Iterator;
-import java.util.List;
-import java.util.Map;
+import java.util.*;
import org.apache.commons.collections.BidiMap;
import org.apache.commons.collections.bidimap.DualHashBidiMap;
-public class TreePathCache {
+public final class TreePathCache {
private static Map<String,BidiMap> treeCaches = new
HashMap<String,BidiMap>();
@@ -68,7 +64,7 @@
private static String getPathStringFromCache(BidiMap treeCache, int node) {
synchronized(treeCache) {
- TreePathCacheKey key = (TreePathCacheKey) treeCache.getKey(new
Integer(node));
+ TreePathCacheKey key = (TreePathCacheKey)
treeCache.getKey(Integer.valueOf(node));
if (key != null) {
return key.getPath();
}
@@ -84,13 +80,13 @@
private static void addToCache(BidiMap treeCache, String path, int node) {
synchronized(treeCache) {
- treeCache.put(new TreePathCacheKey(path), new Integer(node));
+ treeCache.put(new TreePathCacheKey(path), Integer.valueOf(node));
}
}
private static void removeFromCache(BidiMap treeCache, int node) {
synchronized(treeCache) {
- treeCache.removeValue(new Integer(node));
+ treeCache.removeValue(Integer.valueOf(node));
}
}
@@ -102,7 +98,7 @@
private static void updateCache(BidiMap treeCache, int node, String name) {
synchronized(treeCache) {
- Integer nodeNumber = new Integer(node);
+ Integer nodeNumber = Integer.valueOf(node);
if (treeCache.containsValue(nodeNumber)) {
TreePathCacheKey cKey = (TreePathCacheKey)
treeCache.getKey(nodeNumber);
String path = cKey.getPath();
Index: PropertiesUtil.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer/cmsc/utilities/src/java/com/finalist/cmsc/mmbase/PropertiesUtil.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -b -r1.9 -r1.10
--- PropertiesUtil.java 10 May 2008 16:31:23 -0000 1.9
+++ PropertiesUtil.java 16 May 2008 11:46:32 -0000 1.10
@@ -27,7 +27,7 @@
public class PropertiesUtil {
/** MMbase logging system */
- private static Logger log =
Logging.getLoggerInstance(PropertiesUtil.class.getName());
+ private static final Logger log =
Logging.getLoggerInstance(PropertiesUtil.class.getName());
private final static String DEFAULT = "value";
private final static String DEV = "dev";
Index: TypeUtil.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer/cmsc/utilities/src/java/com/finalist/cmsc/mmbase/TypeUtil.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -b -r1.2 -r1.3
--- TypeUtil.java 26 Nov 2007 11:43:41 -0000 1.2
+++ TypeUtil.java 16 May 2008 11:46:32 -0000 1.3
@@ -12,7 +12,7 @@
import java.util.ArrayList;
import java.util.List;
-public class TypeUtil {
+public final class TypeUtil {
private TypeUtil() {
// utility
Index: TreeUtil.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer/cmsc/utilities/src/java/com/finalist/cmsc/mmbase/TreeUtil.java,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -b -r1.13 -r1.14
--- TreeUtil.java 10 May 2008 16:31:23 -0000 1.13
+++ TreeUtil.java 16 May 2008 11:46:32 -0000 1.14
@@ -10,18 +10,18 @@
package com.finalist.cmsc.mmbase;
import java.util.*;
-import java.util.regex.Pattern;
import java.util.regex.Matcher;
+import java.util.regex.Pattern;
import net.sf.mmapps.commons.bridge.RelationUtil;
import net.sf.mmapps.commons.util.EncodingUtil;
-import org.apache.commons.lang.StringUtils;
-import org.mmbase.bridge.*;
import org.apache.commons.lang.RandomStringUtils;
+import org.apache.commons.lang.StringUtils;
+import org.mmbase.bridge.*;
-public class TreeUtil {
+public final class TreeUtil {
private static final String DESTINATION = "DESTINATION";
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs
