Update of
/var/cvs/contributions/CMSContainer/cmsc/maintenance/src/java/com/finalist/cmsc/maintenance/log
In directory
james.mmbase.org:/tmp/cvs-serv30736/cmsc/maintenance/src/java/com/finalist/cmsc/maintenance/log
Modified Files:
LoggingMMBaseObserver.java
Log Message:
CMSC-907 Code Quality with PMD
Add final modifier to Util classes
Add final modifier to Logger instances
Change Boolean, Integer and Long instantiation to valueOf calls
See also:
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer/cmsc/maintenance/src/java/com/finalist/cmsc/maintenance/log
See also: http://www.mmbase.org/jira/browse/CMSC-907
Index: LoggingMMBaseObserver.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer/cmsc/maintenance/src/java/com/finalist/cmsc/maintenance/log/LoggingMMBaseObserver.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -b -r1.3 -r1.4
--- LoggingMMBaseObserver.java 26 Nov 2007 11:43:46 -0000 1.3
+++ LoggingMMBaseObserver.java 16 May 2008 11:46:33 -0000 1.4
@@ -1,18 +1,18 @@
package com.finalist.cmsc.maintenance.log;
-import org.mmbase.module.core.MMBaseObserver;
+import java.util.ArrayList;
+import java.util.Iterator;
+
import org.mmbase.module.core.MMBase;
+import org.mmbase.module.core.MMBaseObserver;
import org.mmbase.util.logging.Logger;
import org.mmbase.util.logging.Logging;
-import java.util.ArrayList;
-import java.util.Iterator;
-
/**
* @author Jeoffrey Bakker (Finalist IT Group)
*/
-public class LoggingMMBaseObserver implements MMBaseObserver {
- private final static Logger log =
Logging.getLoggerInstance(MMBaseObserver.class);
+public final class LoggingMMBaseObserver implements MMBaseObserver {
+ private static final Logger log =
Logging.getLoggerInstance(MMBaseObserver.class);
private ArrayList<LogConstraint> logLocalConstraints = new
ArrayList<LogConstraint>();
private ArrayList<LogConstraint> logRemoteConstraints = new
ArrayList<LogConstraint>();
@@ -40,7 +40,7 @@
if (logConstraint.matches(machine, number, builder, ctype)) {
log.info("Remote! machine:" + machine + ", number:" + number +
",builder:" + ", ctype:" + ctype);
if (logConstraint.isPrintStrackTrace()) {
- log.info(Logging.stackTrace(new Exception()));
+ log.info(Logging.stackTrace());
}
}
}
@@ -56,7 +56,7 @@
if (logConstraint.matches(machine, number, builder, ctype)) {
log.info("Local! machine:" + machine + ", number:" + number +
",builder:" + builder + ", ctype:" + ctype);
if (logConstraint.isPrintStrackTrace()) {
- log.info(Logging.stackTrace(new Exception()));
+ log.info(Logging.stackTrace());
}
}
}
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs
