Update of
/var/cvs/contributions/CMSContainer/cmsc/contentrepository/src/java/com/finalist/cmsc/repository/forms
In directory
james.mmbase.org:/tmp/cvs-serv30736/cmsc/contentrepository/src/java/com/finalist/cmsc/repository/forms
Modified Files:
SearchAction.java
Log Message:
CMSC-907 Code Quality with PMD
Add final modifier to Util classes
Add final modifier to Logger instances
Change Boolean, Integer and Long instantiation to valueOf calls
See also:
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer/cmsc/contentrepository/src/java/com/finalist/cmsc/repository/forms
See also: http://www.mmbase.org/jira/browse/CMSC-907
Index: SearchAction.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer/cmsc/contentrepository/src/java/com/finalist/cmsc/repository/forms/SearchAction.java,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -b -r1.13 -r1.14
--- SearchAction.java 10 May 2008 16:31:23 -0000 1.13
+++ SearchAction.java 16 May 2008 11:46:36 -0000 1.14
@@ -48,7 +48,7 @@
/**
* MMbase logging system
*/
- private static Logger log =
Logging.getLoggerInstance(SearchAction.class.getName());
+ private static final Logger log =
Logging.getLoggerInstance(SearchAction.class.getName());
@Override
@@ -189,14 +189,14 @@
String stringObjectId = searchForm.getObjectid().trim();
Integer objectId = null;
if (stringObjectId.matches("^\\d+$")) {
- objectId = new Integer(stringObjectId);
+ objectId = Integer.valueOf(stringObjectId);
}
else {
if (cloud.hasNode(stringObjectId)) {
- objectId = new
Integer(cloud.getNode(stringObjectId).getNumber());
+ objectId =
Integer.valueOf(cloud.getNode(stringObjectId).getNumber());
}
else {
- objectId = new Integer(-1);
+ objectId = Integer.valueOf(-1);
}
}
SearchUtil.addEqualConstraint(query, nodeManager,
ContentElementUtil.NUMBER_FIELD, objectId);
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs
