Update of
/var/cvs/contributions/CMSContainer/cmsc/taglib/src/java/com/finalist/cmsc/taglib/image
In directory
james.mmbase.org:/tmp/cvs-serv3660/cmsc/taglib/src/java/com/finalist/cmsc/taglib/image
Modified Files:
ImageTag.java
Log Message:
Dangerous doing != on a string
See also:
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer/cmsc/taglib/src/java/com/finalist/cmsc/taglib/image
Index: ImageTag.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer/cmsc/taglib/src/java/com/finalist/cmsc/taglib/image/ImageTag.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -b -r1.6 -r1.7
--- ImageTag.java 16 May 2008 11:46:36 -0000 1.6
+++ ImageTag.java 2 Jun 2008 21:51:34 -0000 1.7
@@ -1,17 +1,15 @@
package com.finalist.cmsc.taglib.image;
-import org.apache.commons.lang.StringUtils;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.jsp.JspTagException;
+import org.apache.commons.lang.StringUtils;
import org.mmbase.bridge.Node;
import org.mmbase.bridge.jsp.taglib.util.Attribute;
-
import org.mmbase.util.images.Dimension;
import org.mmbase.util.logging.Logger;
import org.mmbase.util.logging.Logging;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.jsp.JspTagException;
-
/**
* This tag renders an html image tag to display an image from MMBase.
*
@@ -136,7 +134,7 @@
try {
String descr = image.getStringValue("description");
- if ((descr != null) && (descr.trim() != "")) {
+ if (StringUtils.isNotBlank(descr)) {
legend.append("<span class=\"" + style + "\">");
legend.append(descr.trim());
legend.append("</span>\n");
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs
