Update of 
/var/cvs/contributions/CMSContainer/cmsc/utilities/src/java/com/finalist/cmsc/editwizard
In directory 
james.mmbase.org:/tmp/cvs-serv19747/cmsc/utilities/src/java/com/finalist/cmsc/editwizard

Modified Files:
        WizardMaker.java 
Log Message:
CMSC-907 Code Quality with PMD
PMD error fixes


See also: 
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer/cmsc/utilities/src/java/com/finalist/cmsc/editwizard
See also: http://www.mmbase.org/jira/browse/CMSC-907


Index: WizardMaker.java
===================================================================
RCS file: 
/var/cvs/contributions/CMSContainer/cmsc/utilities/src/java/com/finalist/cmsc/editwizard/WizardMaker.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -b -r1.4 -r1.5
--- WizardMaker.java    16 May 2008 11:46:33 -0000      1.4
+++ WizardMaker.java    9 Jun 2008 21:23:23 -0000       1.5
@@ -16,12 +16,12 @@
  *
  * @author Nico Klasens
  * @author Wouter Heijke
- * @version $Revision: 1.4 $
+ * @version $Revision: 1.5 $
  */
-public class WizardMaker {
+public final class WizardMaker {
    private static final Logger log = 
Logging.getLoggerInstance(WizardMaker.class.getName());
 
-   private static String DEFAULT_SESSION_KEY = "editwizard";
+   private static final String DEFAULT_SESSION_KEY = "editwizard";
 
    private Cloud cloud;
 
@@ -90,11 +90,9 @@
          session.setAttribute("creation", this.creation);
       }
 
-      if (contentType != null) {
-         if (contentTypes == null) {
+      if (contentType != null && contentTypes == null) {
             contentTypes = new String[] { contentType };
          }
-      }
 
       if (contentTypes == null || contentTypes.length == 0) {
          if (objectNumber != null && !"new".equals(objectNumber)) {
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs

Reply via email to