Update of
/var/cvs/contributions/CMSContainer/cmsc/portal/src/java/com/finalist/pluto/portalImpl/om/window/impl
In directory
james.mmbase.org:/tmp/cvs-serv19747/cmsc/portal/src/java/com/finalist/pluto/portalImpl/om/window/impl
Modified Files:
PortletWindowImpl.java
Log Message:
CMSC-907 Code Quality with PMD
PMD error fixes
See also:
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer/cmsc/portal/src/java/com/finalist/pluto/portalImpl/om/window/impl
See also: http://www.mmbase.org/jira/browse/CMSC-907
Index: PortletWindowImpl.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer/cmsc/portal/src/java/com/finalist/pluto/portalImpl/om/window/impl/PortletWindowImpl.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -b -r1.2 -r1.3
--- PortletWindowImpl.java 26 Nov 2007 11:43:47 -0000 1.2
+++ PortletWindowImpl.java 9 Jun 2008 21:23:23 -0000 1.3
@@ -25,8 +25,6 @@
private ObjectID objectId;
- private String id;
-
private PortletEntity portletEntity;
@@ -43,9 +41,6 @@
* @return the object identifier
*/
public ObjectID getId() {
- if (objectId == null) {
- objectId = ObjectID.createFromString(id);
- }
return objectId;
}
@@ -67,12 +62,11 @@
* @param id
* the new identifier
*/
- public void setId(String id) {
+ public final void setId(String id) {
id = id.toLowerCase();
id = id.replaceAll("[,\\s]+", "");
id = id.replaceAll("[^a-zA-Z_0-9-]", "");
- this.id = id;
- objectId = null;
+ objectId = ObjectID.createFromString(id);
}
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs
