[MMBASE CVS] contributions/CMSContainer/cmsc/portal/src/java/com/finalist/pluto/portalImpl/aggregation PortletFragment.java

[Nico Klasens]

Update of 
/var/cvs/contributions/CMSContainer/cmsc/portal/src/java/com/finalist/pluto/portalImpl/aggregation
In directory 
james.mmbase.org:/tmp/cvs-serv19747/cmsc/portal/src/java/com/finalist/pluto/portalImpl/aggregation

Modified Files:
        PortletFragment.java 
Log Message:
CMSC-907 Code Quality with PMD
PMD error fixes


See also: 
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer/cmsc/portal/src/java/com/finalist/pluto/portalImpl/aggregation
See also: http://www.mmbase.org/jira/browse/CMSC-907


Index: PortletFragment.java
===================================================================
RCS file: 
/var/cvs/contributions/CMSContainer/cmsc/portal/src/java/com/finalist/pluto/portalImpl/aggregation/PortletFragment.java,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -b -r1.12 -r1.13
--- PortletFragment.java        9 May 2008 10:06:55 -0000       1.12
+++ PortletFragment.java        9 Jun 2008 21:23:24 -0000       1.13
@@ -57,7 +57,7 @@
  */
 public class PortletFragment extends AbstractFragment {
 
-   private static Log log = LogFactory.getLog(PortletFragment.class);
+   private static final Log log = LogFactory.getLog(PortletFragment.class);
 
    public static final String PORTLET_ERROR_MSG = "Error occurred in portlet!";
 
@@ -65,7 +65,7 @@
    private PortletWindow portletWindow;
    private StringWriter storedWriter;
 
-   private ArrayList<HeaderResource> headerResources;
+   private List<HeaderResource> headerResources;
 
 
    public PortletFragment(ServletConfig config, Fragment parent, String 
layoutId,
@@ -87,7 +87,7 @@
          setDefaultPreferences(ps);
 
          List<Object> p = portlet.getPortletparameters();
-         if (p.size() > 0) {
+         if (!p.isEmpty()) {
             Iterator<Object> pparams = p.iterator();
             while (pparams.hasNext()) {
                Object objectParam = pparams.next();
@@ -126,7 +126,7 @@
    }
 
 
-   protected void setDefaultPreferences(PreferenceSetImpl ps) {
+   protected final void setDefaultPreferences(PreferenceSetImpl ps) {
       ps.add(PortalConstants.CMSC_OM_PORTLET_ID, 
String.valueOf(portlet.getId()));
       ps.add(PortalConstants.CMSC_OM_PORTLET_DEFINITIONID, 
String.valueOf(portlet.getDefinition()));
    }
@@ -358,7 +358,7 @@
    }
 
 
-   public String getKey() {
+   public final String getKey() {
       return getId(); // "_" + layoutId;
    }
 
_______________________________________________
Cvs mailing list
Cvs@lists.mmbase.org
http://lists.mmbase.org/mailman/listinfo/cvs